feat: Runtime output buffer optimization #3276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: core
keehyuna
force-pushed
the
opt_out_buffer
branch
from
d0ef3cd
to
377248e
Compare
keehyuna
force-pushed
the
opt_out_buffer
branch
from
0a98180
to
4a5f0d1
Compare
I think this PR doesn't have to do with fake tensor as output shape was inferred from trt function( |
peri044
reviewed
Nov 18, 2024
| @@ -263,19 +284,15 @@ std::vector<at::Tensor> execute_engine(std::vector<at::Tensor> inputs, c10::intr | |||
| output_profiler_guard = | |||
| std::make_unique<torch::autograd::profiler::RecordProfile>(compiled_engine->output_profile_path); | |||
| } | |||
| if ((false == compiled_engine->use_pre_allocated_outputs) || shape_changed) { | |||
There was a problem hiding this comment.
!compiled_engine->use_pre_allocated_outputs ?
| return false; | ||
| } | ||
|
|
||
| std::vector<at::Tensor> create_output_tensors(c10::intrusive_ptr<TRTEngine> compiled_engine) { |
There was a problem hiding this comment.
Can we functionalize inputs allocation/creation in the execute engine similar to this ? ( I posted a similar comment in your wrapper module PR)
narendasan
reviewed
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Latency hiding by creating the output tensor for next output buffer
Fixes #3275
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: