Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade tensorrt dependency to >=10.3.0,<=10.6.0 #3286

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

upgrade tensorrt dependency to >=10.3.0,<=10.6.0 #3286

wants to merge 40 commits into from

Conversation

lanluo-nvidia
Copy link
Collaborator

@lanluo-nvidia lanluo-nvidia commented Nov 9, 2024 •
edited
Loading

Description

upgrade tensorrt dependency to >=10.3.0,<=10.6.0

in the docker container: it is always shipped with latest tensorrt 10.6.0

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia added WIP Work is in progress, pull request should not be merged yet build-release-artifacts Build the release artifacts labels Nov 9, 2024
@lanluo-nvidia lanluo-nvidia self-assigned this Nov 9, 2024
@lanluo-nvidia lanluo-nvidia changed the title upgrade tensorrt dependency upgrade tensorrt dependency(WIP) Nov 9, 2024
@github-actions github-actions bot added the component: build system Issues re: Build system label Nov 9, 2024
@lanluo-nvidia lanluo-nvidia changed the title upgrade tensorrt dependency(WIP) upgrade tensorrt dependency to >=10.3.0,<=10.6.0 Nov 9, 2024
zewenli98
zewenli98 reviewed Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you refer to the previous PR #3071 to make sure the modification is complete?

@lanluo-nvidia lanluo-nvidia changed the base branch from lluo/tensorrt_test_workflow to lluo/tensorrt_test_windows_wf November 14, 2024 07:21
@github-actions github-actions bot added documentation Improvements or additions to documentation component: tests Issues re: Tests component: core Issues re: The core compiler component: api [Python] Issues re: Python API component: runtime component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Nov 14, 2024
@lanluo-nvidia lanluo-nvidia changed the base branch from lluo/tensorrt_test_windows_wf to main November 14, 2024 22:54
@github-actions github-actions bot removed documentation Improvements or additions to documentation component: tests Issues re: Tests component: core Issues re: The core compiler component: api [Python] Issues re: Python API component: runtime component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Nov 14, 2024
@narendasan
Copy link
Collaborator

@zewenli98 can you rebase this branch with main to see if it passes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zewenli98 zewenli98 zewenli98 left review comments

@narendasan narendasan Awaiting requested review from narendasan

Assignees

@zewenli98 zewenli98

Labels
build-release-artifacts Build the release artifacts cla signed component: build system Issues re: Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lanluo-nvidia @narendasan @zewenli98 @facebook-github-bot