Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change decomposition default table due to upstream torch change #3291

Merged
merged 1 commit into from
Nov 13, 2024
Merged

change decomposition default table due to upstream torch change #3291

merged 1 commit into from
Nov 13, 2024

Conversation

lanluo-nvidia
Copy link
Collaborator

Description

change decomposition default table due to upstream torch change:
pytorch/pytorch#140085

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia self-assigned this Nov 12, 2024
@github-actions github-actions bot added component: lowering Issues re: The lowering / preprocessing passes component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Nov 12, 2024
narendasan
narendasan reviewed Nov 12, 2024
View reviewed changes
py/torch_tensorrt/dynamo/lowering/_decompositions.py
@@ -412,7 +412,8 @@ def get_decompositions(
return {**CORE_ATEN_DECOMPOSITIONS_FILTERED, **TORCH_TRT_DECOMPOSITIONS}
else:
# changes made here due to torch2.6 changes https://github.com/pytorch/pytorch/pull/135080
decomp_table = _decomp_table_to_post_autograd_aten()
# changes made here due to torch2.6 changes https://github.com/pytorch/pytorch/pull/140085
decomp_table = default_decompositions()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peri044 can we take a quick pass on the decomp set?

@lanluo-nvidia lanluo-nvidia mentioned this pull request Nov 12, 2024
Merged
7 tasks
narendasan
narendasan approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lanluo-nvidia this looks good to merge. Seems like they in place replace in pytorch so should work for us

@lanluo-nvidia lanluo-nvidia merged commit daffc7c into main Nov 13, 2024
67 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@gs-olive gs-olive Awaiting requested review from gs-olive

@peri044 peri044 Awaiting requested review from peri044

Assignees

@lanluo-nvidia lanluo-nvidia

Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lanluo-nvidia @narendasan @facebook-github-bot