Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get decompositions only for CIA ops #3297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HolyWu
Copy link
Contributor

@HolyWu HolyWu commented Nov 18, 2024

Description

torch.export.default_decompositions() will get the same opset of decompositions as torch._decomp.core_aten_decompositions(), which is what you get when enable_experimental_decompositions=True. That is unwanted in enable_experimental_decompositions=False path. We only need decompositions for CIA ops here.

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: lowering Issues re: The lowering / preprocessing passes component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Nov 18, 2024
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Based on my understanding, the three tables with this change are (which used to be the case before Pytorch upstream changes)

  1. Fixed set of torch decompositions that we maintain (since upstream can keep changing)
  2. All CIA op decompositions
  3. Our custom decompositions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants