Code

Nccl ops correction changes#3387

Code

Merged

zewenli98 merged 14 commits intomainpytorch/TensorRT:mainfrom nccl_ops_additionalpytorch/TensorRT:nccl_ops_additionalCopy head branch name to clipboardMar 25, 2025

Commits

Commits on Mar 24, 2025

• backend changes to decomposition for transpose

  apbose

  committed
  95999b9

  Copy full SHA for 95999b9

• adding back detach op in ops to be deleted in decomposition

  apbose

  committed
  c6c87bb

  Copy full SHA for c6c87bb

• nccl ops correction

  apbose

  committed
  7476b05

  Copy full SHA for 7476b05

• using detach lowering pass

  apbose

  committed
  d0c9671

  Copy full SHA for d0c9671

• adding test cases

  apbose

  committed
  7200055

  Copy full SHA for 7200055

• adding the test script and correction to the backend

  apbose

  committed
  de48feb

  Copy full SHA for de48feb

• nccl ops address review

  apbose

  committed
  de54bb1

  Copy full SHA for de54bb1

• restructuring the code to include option use_distributed_mode_trace

  apbose

  committed
  dbe3ef2

  Copy full SHA for dbe3ef2

• Correcting the option in _settings.py and improving the error logging

  apbose

  committed
  d3ce998

  Copy full SHA for d3ce998

• Improving the option logging

  apbose

  committed
  8d6ef41

  Copy full SHA for 8d6ef41

• removing the complex components call and changes in this PR- Please note that to make llama3 work, you need to checkout before this

  apbose

  committed
  a58ba49

  Copy full SHA for a58ba49

• Implementing the Option 1-warning recommending the users to use use_distributed_mode_trace=True

  apbose

  committed
  db25058

  Copy full SHA for db25058

• addressing review comments- making dynamic=None in torch.compile and changing the option description

  apbose

  committed
  825ae45

  Copy full SHA for 825ae45

• Option 1 further modification- recommended set of options in test/examples, including the warning in backend, destroying processes while exiting

  apbose

  committed
  c556dec

  Copy full SHA for c556dec