slight code reorg and bug correction for cross_compile #3472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: api [Python]
narendasan
reviewed
Apr 14, 2025
| # insert the no_placeholder node in the graph which should be replaced to the actual execute_engine node while load in the windows | ||
| trt_node = gm.graph.call_function( | ||
| torch.ops.tensorrt.no_op_placeholder_for_execute_engine.default, | ||
| (trt_module_node.args, *engine_info), |
There was a problem hiding this comment.
Do we still need to unpack this list?
There was a problem hiding this comment.
We would still need to unpack the list. Else while loading in windows it shows
File "C:\Users\abose\Documents\work\TensorRT\torchTRT\Lib\site-packages\torch\_export\serde\serialize.py", line 2258, in deserialize_inputs
args.append(actual_args[schema_arg.name])
~~~~~~~~~~~^^^^^^^^^^^^^^^^^
KeyError: 'name'
narendasan
reviewed
Apr 15, 2025
| @@ -144,6 +144,7 @@ def no_op_placeholder_for_execute_engine( | |||
| serialized_hardware_compatible: str, | |||
| serialized_metadata: str, | |||
| serialized_target_platform: str, | |||
| serialized_require_output_allocator: str, | |||
There was a problem hiding this comment.
Move this placeholder op to runtime/meta_ops
narendasan
reviewed
Apr 15, 2025
| getitem_nodes = trt_node.users | ||
| for idx, getitem_node in enumerate(getitem_nodes): | ||
| getitem_node.meta["val"] = trt_node.meta["val"][idx] | ||
| no_op_placeholder_node.replace_all_uses_with(trt_node) |
There was a problem hiding this comment.
Can you add a multi output testcase to the cross compile tests?
apbose
commented
Apr 15, 2025
| no_op_placeholder_node.replace_all_uses_with(trt_node) | ||
| getitem_nodes = trt_node.users | ||
| for idx, getitem_node in enumerate(getitem_nodes): | ||
| getitem_node.meta["val"] = trt_node.meta["val"][idx] | ||
|
|
There was a problem hiding this comment.
@narendasan this is the part which should address the bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following for the cross_compile_for_windows feature-
cross_compile_flagwithcross_compile_module