[CPU] enable int8_dynamic_activation_int4_weight with Int4CPULayout #2128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2128
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 35ece3b with merge base e3db2b2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Xia-Weiwen
added
cpu
quantize
topic: new feature
jerryzh168
reviewed
Apr 28, 2025
| torch.compile(m, fullgraph=True, dynamic=True), | ||
| *example_inputs, | ||
| ) | ||
| assert "_weight_int4pack_mm_for_cpu" in code[0] |
There was a problem hiding this comment.
I remember this op is weight only quant?
There was a problem hiding this comment.
Yes. This op is used here because we don't have an op to compute da8w4 on CPU yet. So it will fallback to explicit dequantization and call of this op.
leslie-fang-intel
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable quantization of model with
int8_dynamic_activation_int4_weightandInt4CPULayout.Test plan