Skip to content

metal lowbit kernels: qmv_fast optimization #2167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

manuelcandales
Copy link
Contributor

@manuelcandales manuelcandales commented May 3, 2025

This PR does the following modifications:

  • Previously, the metal lowbit kernels consumed the scales and zeros transposed, (i.e. num_groups x N). This PR changes that, so that now, the scales and zeros are consumed in the same shape as produced by the _quantize function, (i.e. N x num_groups)
  • Packing for 3, 5, 6, & 7 bit is changed. The bits are stored contiguously now, jumping to the next byte when we reach the end of the current byte.
  • qmv_fast optimization from MLX is adapted and expanded to support 1, 5 & 7 bits (not currently supported in MLX)

Copy link

pytorch-bot bot commented May 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2167

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit c200b29 with merge base 4850998 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 3, 2025
@manuelcandales manuelcandales added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants