Ensure the const-ness of the data member #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-examples-preview canceled.
|
lancerts
force-pushed
the
custom-dataset-const
branch
from
e2ae5c4 to
5e508df
Compare
|
@msaroufim FYI, rebased to main so this change is tested by the CI job and passed the test. |
YinZhengxun
pushed a commit
to YinZhengxun/mt-exercise-02
that referenced
this pull request
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
datavariable loads from the info.txt and encodes the info in pair <image path, ground truth label>.The program should not modify this information during the execution and thus ensure the const-ness of the
datavariable.Testing Done
Tested the program via libtorch (2.1.2) with cuda 12.1 using both the release and debug build.