[Executorch][llama] Renamed quantized_kv_cache to custom_kv_cache #10061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dim 1 or 2 Pull Request resolved: #9943 For quantized SDPA we want to evaluate performance impact of having seq at dim 1 as well as dim 2. This diff refactors the code to enable this. The same should be done also for float SDPA but left for future. ghstack-source-id: 277233484 @exported-using-ghexport Differential Revision: [D71833060](https://our.internmc.facebook.com/intern/diff/D71833060/)
Pull Request resolved: #9944 Because old name was misnomer ghstack-source-id: 277233486 @exported-using-ghexport Differential Revision: [D71833067](https://our.internmc.facebook.com/intern/diff/D71833067/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10061
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit aa0b2b8 with merge base ad6f5ee ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
requested review from
iseeyuan,
larryliu0820 and
swolchok
as code owners
kirklandsign
added
the
release notes: examples
kirklandsign
approved these changes
Apr 10, 2025
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
…0061) Because old name was misnomer ghstack-source-id: 277233486 @exported-using-ghexport Differential Revision: [D71833067](https://our.internmc.facebook.com/intern/diff/D71833067/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #9944 by @kimishpatel
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/171/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/171/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/170/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/171/orig
@diff-train-skip-merge