Arm backend: Add support for sqrt #9928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fumchin
added
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9928
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7a4622b with merge base 91a14f1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
oscarandersson8218
requested changes
Apr 7, 2025
- implement sqrt as pow(x, 0.5) - Added tests for sqrt Signed-off-by: Fang-Ching <[email protected]> Change-Id: I24c8fcbbafbca8e341825aa6792bfb1eaf426194
oscarandersson8218
approved these changes
Apr 9, 2025
There was a problem hiding this comment.
Looks good to me! CI failures should be unrelated. Just waiting for #9451 to be merged before merging this.
zingo
approved these changes
Apr 11, 2025
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
The sqrt operation is implemented via the pow operator, sqrt(x) = pow(x, 0.5). Signed-off-by: Fang-Ching <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sqrt operation is implemented via the pow operator, sqrt(x) = pow(x, 0.5).
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218