[Executorch][llama] Enable quantized sdpa #9945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable leveraging quantized sdpa op when quantized kv cache is used. Instead of adding yet another arg, at the moment I have chosen to leverage quantize_kv_cache option. Differential Revision: [D71833064](https://our.internmc.facebook.com/intern/diff/D71833064/) [ghstack-poisoned]
kimishpatel
requested review from
jackzhxng,
iseeyuan,
larryliu0820,
swolchok and
lucylq
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9945
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit ad54e4e with merge base ad6f5ee ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kimishpatel
added a commit
that referenced
this pull request
Apr 7, 2025
Enable leveraging quantized sdpa op when quantized kv cache is used. Instead of adding yet another arg, at the moment I have chosen to leverage quantize_kv_cache option. Differential Revision: [D71833064](https://our.internmc.facebook.com/intern/diff/D71833064/) ghstack-source-id: 276640303 Pull Request resolved: #9945
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71833064 |
kimishpatel
added
the
release notes: examples
Enable leveraging quantized sdpa op when quantized kv cache is used. Instead of adding yet another arg, at the moment I have chosen to leverage quantize_kv_cache option. Differential Revision: [D71833064](https://our.internmc.facebook.com/intern/diff/D71833064/) [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Apr 8, 2025
Pull Request resolved: #9945 Enable leveraging quantized sdpa op when quantized kv cache is used. Instead of adding yet another arg, at the moment I have chosen to leverage quantize_kv_cache option. Differential Revision: [D71833064](https://our.internmc.facebook.com/intern/diff/D71833064/) ghstack-source-id: 276903837
|
This pull request was exported from Phabricator. Differential Revision: D71833064 |
Enable leveraging quantized sdpa op when quantized kv cache is used. Instead of adding yet another arg, at the moment I have chosen to leverage quantize_kv_cache option. Differential Revision: [D71833064](https://our.internmc.facebook.com/intern/diff/D71833064/) [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Apr 9, 2025
Pull Request resolved: #9945 Enable leveraging quantized sdpa op when quantized kv cache is used. Instead of adding yet another arg, at the moment I have chosen to leverage quantize_kv_cache option. ghstack-source-id: 276951801 Differential Revision: [D71833064](https://our.internmc.facebook.com/intern/diff/D71833064/)
|
This pull request was exported from Phabricator. Differential Revision: D71833064 |
Enable leveraging quantized sdpa op when quantized kv cache is used. Instead of adding yet another arg, at the moment I have chosen to leverage quantize_kv_cache option. Differential Revision: [D71833064](https://our.internmc.facebook.com/intern/diff/D71833064/) [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Apr 9, 2025
Pull Request resolved: #9945 Enable leveraging quantized sdpa op when quantized kv cache is used. Instead of adding yet another arg, at the moment I have chosen to leverage quantize_kv_cache option. ghstack-source-id: 276961554 Differential Revision: [D71833064](https://our.internmc.facebook.com/intern/diff/D71833064/)
|
This pull request was exported from Phabricator. Differential Revision: D71833064 |
kirklandsign
approved these changes
Apr 9, 2025
Enable leveraging quantized sdpa op when quantized kv cache is used. Instead of adding yet another arg, at the moment I have chosen to leverage quantize_kv_cache option. Differential Revision: [D71833064](https://our.internmc.facebook.com/intern/diff/D71833064/) [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Apr 9, 2025
Pull Request resolved: #9945 Enable leveraging quantized sdpa op when quantized kv cache is used. Instead of adding yet another arg, at the moment I have chosen to leverage quantize_kv_cache option. ghstack-source-id: 277160634 Differential Revision: [D71833064](https://our.internmc.facebook.com/intern/diff/D71833064/)
|
This pull request was exported from Phabricator. Differential Revision: D71833064 |
Enable leveraging quantized sdpa op when quantized kv cache is used. Instead of adding yet another arg, at the moment I have chosen to leverage quantize_kv_cache option. Differential Revision: [D71833064](https://our.internmc.facebook.com/intern/diff/D71833064/) [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Apr 10, 2025
Pull Request resolved: #9945 Enable leveraging quantized sdpa op when quantized kv cache is used. Instead of adding yet another arg, at the moment I have chosen to leverage quantize_kv_cache option. ghstack-source-id: 277233485 Differential Revision: [D71833064](https://our.internmc.facebook.com/intern/diff/D71833064/)
|
This pull request was exported from Phabricator. Differential Revision: D71833064 |
facebook-github-bot
merged commit 46fe905
into
gh/kimishpatel/172/base
87 of 90 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Apr 10, 2025
Pull Request resolved: #9945 Enable leveraging quantized sdpa op when quantized kv cache is used. Instead of adding yet another arg, at the moment I have chosen to leverage quantize_kv_cache option. ghstack-source-id: 277233485 Differential Revision: [D71833064](https://our.internmc.facebook.com/intern/diff/D71833064/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Enable leveraging quantized sdpa op when quantized kv cache is used. Instead of adding yet another arg, at the moment I have chosen to leverage quantize_kv_cache option.
Differential Revision: D71833064