memory_planning algos take the specs as inputs instead of calculating them themselves #9952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9952
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 7a8e8bf with merge base a1af1ff ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72600295 |
JacobSzwejbka
force-pushed
the
export-D72600295
branch
from
3cf1bc2 to
c54309b
Compare
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Apr 8, 2025
… them themselves (pytorch#9952) Summary: Refactor the algos to not calculate the active set of nodes themselves. Future work should refactor apply_algo more to not be recursive and actually smartly handle lifespans on control flow. Made the memory planning suite a class so that the algo list is easily configureable without having to make a wrapper function. Differential Revision: D72600295
|
This pull request was exported from Phabricator. Differential Revision: D72600295 |
JacobSzwejbka
added
release notes: api
skrtskrtfb
approved these changes
Apr 8, 2025
JacobSzwejbka
force-pushed
the
export-D72600295
branch
from
c54309b to
25e0164
Compare
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Apr 9, 2025
… them themselves (pytorch#9952) Summary: Refactor the algos to not calculate the active set of nodes themselves. Future work should refactor apply_algo more to not be recursive and actually smartly handle lifespans on control flow. Made the memory planning suite a class so that the algo list is easily configureable without having to make a wrapper function. Reviewed By: skrtskrtfb Differential Revision: D72600295
|
This pull request was exported from Phabricator. Differential Revision: D72600295 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Apr 9, 2025
… them themselves (pytorch#9952) Summary: Refactor the algos to not calculate the active set of nodes themselves. Future work should refactor apply_algo more to not be recursive and actually smartly handle lifespans on control flow. Made the memory planning suite a class so that the algo list is easily configureable without having to make a wrapper function. Reviewed By: skrtskrtfb Differential Revision: D72600295
JacobSzwejbka
force-pushed
the
export-D72600295
branch
from
25e0164 to
1e214cb
Compare
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Apr 9, 2025
… them themselves (pytorch#9952) Summary: Refactor the algos to not calculate the active set of nodes themselves. Future work should refactor apply_algo more to not be recursive and actually smartly handle lifespans on control flow. Made the memory planning suite a class so that the algo list is easily configureable without having to make a wrapper function. Reviewed By: skrtskrtfb Differential Revision: D72600295
JacobSzwejbka
force-pushed
the
export-D72600295
branch
from
1e214cb to
c7cc64d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72600295 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D72600295 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Apr 9, 2025
… them themselves (pytorch#9952) Summary: Pull Request resolved: pytorch#9952 Refactor the algos to not calculate the active set of nodes themselves. Future work should refactor apply_algo more to not be recursive and actually smartly handle lifespans on control flow. Made the memory planning suite a class so that the algo list is easily configureable without having to make a wrapper function. Reviewed By: skrtskrtfb Differential Revision: D72600295
JacobSzwejbka
force-pushed
the
export-D72600295
branch
from
c7cc64d to
73341d0
Compare
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Apr 9, 2025
… them themselves (pytorch#9952) Summary: Refactor the algos to not calculate the active set of nodes themselves. Future work should refactor apply_algo more to not be recursive and actually smartly handle lifespans on control flow. Made the memory planning suite a class so that the algo list is easily configureable without having to make a wrapper function. Reviewed By: skrtskrtfb Differential Revision: D72600295
JacobSzwejbka
force-pushed
the
export-D72600295
branch
from
73341d0 to
c155354
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72600295 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Apr 9, 2025
… them themselves (pytorch#9952) Summary: Pull Request resolved: pytorch#9952 Refactor the algos to not calculate the active set of nodes themselves. Future work should refactor apply_algo more to not be recursive and actually smartly handle lifespans on control flow. Made the memory planning suite a class so that the algo list is easily configureable without having to make a wrapper function. Reviewed By: skrtskrtfb Differential Revision: D72600295
JacobSzwejbka
force-pushed
the
export-D72600295
branch
from
c155354 to
a3693fe
Compare
tarun292
approved these changes
Apr 9, 2025
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Apr 9, 2025
… them themselves (pytorch#9952) Summary: Refactor the algos to not calculate the active set of nodes themselves. Future work should refactor apply_algo more to not be recursive and actually smartly handle lifespans on control flow. Made the memory planning suite a class so that the algo list is easily configureable without having to make a wrapper function. Reviewed By: tarun292, skrtskrtfb Differential Revision: D72600295
JacobSzwejbka
force-pushed
the
export-D72600295
branch
from
a3693fe to
0ab5ffe
Compare
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Apr 9, 2025
… them themselves (pytorch#9952) Summary: Refactor the algos to not calculate the active set of nodes themselves. Future work should refactor apply_algo more to not be recursive and actually smartly handle lifespans on control flow. Made the memory planning suite a class so that the algo list is easily configureable without having to make a wrapper function. Reviewed By: tarun292, skrtskrtfb Differential Revision: D72600295
JacobSzwejbka
force-pushed
the
export-D72600295
branch
from
0ab5ffe to
d62ef46
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72600295 |
… them themselves (pytorch#9952) Summary: Pull Request resolved: pytorch#9952 Refactor the algos to not calculate the active set of nodes themselves. Future work should refactor apply_algo more to not be recursive and actually smartly handle lifespans on control flow. Made the memory planning suite a class so that the algo list is easily configureable without having to make a wrapper function. Reviewed By: tarun292, skrtskrtfb Differential Revision: D72600295
JacobSzwejbka
force-pushed
the
export-D72600295
branch
from
d62ef46 to
7a8e8bf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72600295 |
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
… them themselves Differential Revision: D72600295 Pull Request resolved: #9952
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refactor the algos to not calculate the active set of nodes themselves. Future work should refactor apply_algo more to not be recursive and actually smartly handle lifespans on control flow.
Made the memory planning suite a class so that the algo list is easily configureable without having to make a wrapper function.
Differential Revision: D72600295
cc @angelayi