Support child profilers adding their deviceProperties to logger #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sraikund16 , could you help review this? |
|
This is a cool idea, thanks for submitting this. I think this will affect our internal testing so I'll try to dedicate some time to make sure things work this week. |
sraikund16
reviewed
Nov 5, 2024
| @@ -123,6 +123,22 @@ void ChromeTraceLogger::handleTraceStart( | |||
| "traceEvents": [)JSON"; | |||
| } | |||
|
|
|||
| void ChromeTraceLogger::handleTraceStart( | |||
There was a problem hiding this comment.
wondering if we want to get rid of definition on L107
sraikund16
reviewed
Nov 5, 2024
| @@ -66,6 +66,13 @@ class MemoryTraceLogger : public ActivityLogger { | |||
| metadata_ = metadata; | |||
| } | |||
|
|
|||
| void handleTraceStart( | |||
sraikund16
reviewed
Nov 5, 2024
| @@ -306,7 +308,17 @@ void CuptiActivityProfiler::processTraceInternal(ActivityLogger& logger) { | |||
| for (auto& pair : versionMetadata_) { | |||
| addMetadata(pair.first, pair.second); | |||
| } | |||
| logger.handleTraceStart(metadata_); | |||
| std::vector<std::string> device_properties; | |||
| if (auto props = devicePropertiesJson(); !props.empty()) { | |||
There was a problem hiding this comment.
nit: can we define these vars outside of the if statement? I think our internal linter will complain about lines like these
|
@sraikund16 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
aaronenyeshi
approved these changes
Nov 6, 2024
sraikund16
pushed a commit
to sraikund16/kineto
that referenced
this pull request
Nov 6, 2024
…rch#1008) Summary: This patch is intended to support our out-of-tree Kineto plugin in adding its deviceProperties. Reviewed By: aaronenyeshi Differential Revision: D65496183 Pulled By: sraikund16
|
@sraikund16 merged this pull request in 2fb2248. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is intended to support our out-of-tree Kineto plugin in adding its deviceProperties.