Omit Non Human Readable Names in Kineto #1027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D67923913 |
sraikund16
added a commit
to sraikund16/kineto
that referenced
this pull request
Jan 8, 2025
Summary: When running with_stack there are instances where the JSON output is configured improperly because certain values are non-human readable. We should at least patch this by omitting such values until we find a long-term solution. Reviewed By: aaronenyeshi, mkyybx Differential Revision: D67923913
sraikund16
force-pushed
the
export-D67923913
branch
from
a5d9e92 to
ebb9894
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67923913 |
Summary: When running with_stack there are instances where the JSON output is configured improperly because certain values are non-human readable. We should at least patch this by omitting such values until we find a long-term solution. Reviewed By: aaronenyeshi, mkyybx Differential Revision: D67923913
sraikund16
force-pushed
the
export-D67923913
branch
from
ebb9894 to
d9ffed7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67923913 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D67923913 |
|
This pull request has been merged in 7ae1ce8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: When running with_stack there are instances where the JSON output is configured improperly because certain values are non-human readable. We should at least patch this by omitting such values until we find a long-term solution.
Reviewed By: aaronenyeshi, mkyybx
Differential Revision: D67923913