Rework roctracer shutdown flushing #833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeffdaily This look good now? |
aaronenyeshi
approved these changes
Nov 20, 2023
|
@aaronenyeshi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@aaronenyeshi merged this pull request in 490f305. |
mwootton
added a commit
to ROCm/kineto
that referenced
this pull request
Nov 30, 2023
Summary: Reworked roctracer flush on shutdown. Removing a race condition added while removing the original race condition. :) Previous implementation had a deadlock in the case where the op buffer had filled and flushed on its own immediately before shutdown. This new approach is simpler but has to continuously log correlation ids of completed async ops. This is done on the roctracer supplied callback thread so it is not an overhead/performance issue. Previous attempt was over-optimized at the cost of not working correctly. Oops. Pull Request resolved: pytorch#833 Reviewed By: xuzhao9 Differential Revision: D51473804 Pulled By: aaronenyeshi fbshipit-source-id: 7a7bea1356aea7e9a719fffe8e50735d072843f6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked roctracer flush on shutdown. Removing a race condition added while removing the original race condition. :)
Previous implementation had a deadlock in the case where the op buffer had filled and flushed on its own immediately before shutdown.
This new approach is simpler but has to continuously log correlation ids of completed async ops. This is done on the roctracer supplied callback thread so it is not an overhead/performance issue. Previous attempt was over-optimized at the cost of not working correctly. Oops.