Re-land "D50471345: [Kineto] Make CUPTI lazy init" #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D51432016 |
aaronenyeshi
requested review from
chaekit,
davidberard98,
briancoutinho and
anupambhatnagar
Summary: There are unit tests in APS trainer that require parsing the log messages to verify that there are GPU records being saved. We should keep log messages at least at INFO level for unit tests. Test Plan: CI Reviewed By: satgera, davidberard98 Differential Revision: D51431805 Pulled By: aaronenyeshi
Summary: This diff was reverted due to failures related to lazy init causing suppressed log messages. D51431805 should fix that issue by avoiding suppressed log messages for unit tests. Re-land this diff to make CUPTI lazy init, see D50471345 for specifics. Test Plan: CI Reviewed By: satgera Differential Revision: D51432016 Pulled By: aaronenyeshi
aaronenyeshi
force-pushed
the
export-D51432016
branch
from
3f6fdb6 to
b453fc3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51432016 |
|
@aaronenyeshi merged this pull request in b2db477. |
|
This pull request has been reverted by 1f250d4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff was reverted due to failures related to lazy init causing suppressed log messages. D51431805 should fix that issue by avoiding suppressed log messages for unit tests. Re-land this diff to make CUPTI lazy init, see D50471345 for specifics.
Differential Revision: D51432016
Pulled By: aaronenyeshi