Fix Bandwidth Calculations in JSON #993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D63422014 |
|
This pull request was exported from Phabricator. Differential Revision: D63422014 |
sraikund16
added a commit
to sraikund16/kineto
that referenced
this pull request
Sep 26, 2024
Summary: Pull Request resolved: pytorch#993 We are using TSC timestamps as durations instead of the conversion to seconds. We should never call the start/end bare, only use the duration() and timstamp() functions Differential Revision: D63422014
sraikund16
force-pushed
the
export-D63422014
branch
from
ba4a84a to
90351d3
Compare
Summary: Pull Request resolved: pytorch#993 We are using TSC timestamps as durations instead of the conversion to seconds. We should never call the start/end bare, only use the duration() and timstamp() functions Differential Revision: D63422014
|
This pull request was exported from Phabricator. Differential Revision: D63422014 |
sraikund16
force-pushed
the
export-D63422014
branch
from
90351d3 to
1f58ef3
Compare
davidberard98
approved these changes
Sep 26, 2024
aaronenyeshi
approved these changes
Sep 26, 2024
|
This pull request has been merged in b5c85da. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We are using TSC timestamps as durations instead of the conversion to seconds. We should never call the start/end bare, only use the duration() and timstamp() functions
Differential Revision: D63422014