Do Not Cache PID/TID in Logging #994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D63668265 |
|
This pull request was exported from Phabricator. Differential Revision: D63668265 |
sraikund16
added a commit
to sraikund16/kineto
that referenced
this pull request
Oct 1, 2024
Summary: Pull Request resolved: pytorch#994 S451588 was caused by the LOG macro caching values that would then be copied to other processes via forking. In general, we should probably use fork handlers to clear out said variables, but from a hygiene point of view we should also not be changing control flow based on logging. For this reason, the pid/tid retrieval in logging should get the cached variable if it exists, but never do the caching itself. Differential Revision: D63668265
sraikund16
force-pushed
the
export-D63668265
branch
from
28b7988 to
a2f124e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63668265 |
sraikund16
added a commit
to sraikund16/kineto
that referenced
this pull request
Oct 1, 2024
Summary: Pull Request resolved: pytorch#994 S451588 was caused by the LOG macro caching values that would then be copied to other processes via forking. In general, we should probably use fork handlers to clear out said variables, but from a hygiene point of view we should also not be changing control flow based on logging. For this reason, the pid/tid retrieval in logging should get the cached variable if it exists, but never do the caching itself. Differential Revision: D63668265
sraikund16
force-pushed
the
export-D63668265
branch
from
a2f124e to
26602c9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63668265 |
sraikund16
added a commit
to sraikund16/kineto
that referenced
this pull request
Oct 1, 2024
Summary: Pull Request resolved: pytorch#994 S451588 was caused by the LOG macro caching values that would then be copied to other processes via forking. In general, we should probably use fork handlers to clear out said variables, but from a hygiene point of view we should also not be changing control flow based on logging. For this reason, the pid/tid retrieval in logging should get the cached variable if it exists, but never do the caching itself. Differential Revision: D63668265
sraikund16
force-pushed
the
export-D63668265
branch
from
26602c9 to
a39cec1
Compare
Summary: Pull Request resolved: pytorch#994 S451588 was caused by the LOG macro caching values that would then be copied to other processes via forking. In general, we should probably use fork handlers to clear out said variables, but from a hygiene point of view we should also not be changing control flow based on logging. For this reason, the pid/tid retrieval in logging should get the cached variable if it exists, but never do the caching itself. Differential Revision: D63668265
|
This pull request was exported from Phabricator. Differential Revision: D63668265 |
sraikund16
force-pushed
the
export-D63668265
branch
from
a39cec1 to
a922a48
Compare
aaronenyeshi
approved these changes
Oct 2, 2024
|
This pull request has been merged in 78737f1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: S451588 was caused by the LOG macro caching values that would then be copied to other processes via forking. In general, we should probably use fork handlers to clear out said variables, but from a hygiene point of view we should also not be changing control flow based on logging. For this reason, the pid/tid retrieval in logging should get the cached variable if it exists, but never do the caching itself.
Differential Revision: D63668265