Skip to content

Fix the link of torch.compile backend #113777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix the link of torch.compile backend #113777

wants to merge 1 commit into from

Conversation

niyatikarthik
Copy link

@niyatikarthik niyatikarthik commented Nov 15, 2023 •
edited
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 15, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113777

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 924cbe8 with merge base 7f9fafe (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 15, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: niyatikarthik / name: NK (924cbe8)

@github-actions GitHub Actions
Copy link
Contributor

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

zou3519
zou3519 reviewed Nov 16, 2023
View reviewed changes
torch/__init__.py
@@ -1697,7 +1697,7 @@ def compile(model: Optional[Callable] = None, *,

- Experimental or debug in-tree backends can be seen with `torch._dynamo.list_backends(None)`

- To register an out-of-tree custom backend: https://pytorch.org/docs/main/compile/custom-backends.html
- To register an out-of-tree custom backend: https://pytorch.org/docs/stable/torch.compiler_custom_backends.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a cross-reference as so: https://docs.readthedocs.io/en/stable/guides/cross-referencing-with-sphinx.html so that the code works with multiple versions of PyTorch.

zou3519
zou3519 requested changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 17, 2023
@github-actions GitHub Actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Jan 16, 2024
@github-actions github-actions bot closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zou3519 zou3519 zou3519 requested changes

Assignees
No one assigned
Labels
open source Stale triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backend List website not working
4 participants
@niyatikarthik @zou3519 @pytorchbot @janeyx99