Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] CQL compatibility with compile #2553

Open
wants to merge 31 commits into
base: gh/vmoens/36/base
Choose a base branch
from

Conversation

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Nov 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2553

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 2 Pending, 8 Unrelated Failures

As of commit bbaa142 with merge base b4b5944 (image):

NEW FAILURES - The following jobs have failed:

  • Continuous Benchmark (PR) / CPU Pytest benchmark (gh)
    FAILED ../../../../../../tmp/test_objectives_benchmarks.py::test_iql_speed[True-None] - torch._dynamo.exc.Unsupported: Graph break under GenericContextWrappingVariable
  • Continuous Benchmark (PR) / GPU Pytest benchmark (gh)
    FAILED ../../../../tmp/test_objectives_benchmarks.py::test_iql_speed[reduce-overhead-backward] - torch._dynamo.exc.Unsupported: Graph break due to unsupported builtin _C.expand. This function is either a Python builtin (e.g. _warnings.warn) or a third-party C/C++ Python extension (perhaps created with pybind). If it is a Python builtin, please file an issue on GitHub so the PyTorch team can add support for it and see the next case for a workaround. If it is a third-party C/C++ Python extension, please either wrap it into a PyTorch-understood custom operator (see https://pytorch.org/tutorials/advanced/custom_ops_landing_page.html for more details) or, if it is traceable, use torch.compiler.allow_in_graph.
  • SOTA Tests on Linux / tests (3.9, 12.1) / linux-job (gh)
    RuntimeError: Command docker exec -t cb4fb1c2c5767f60bdff15a4289186da8ca20b70154797e56a213213c5153144 /exec failed with exit code 1
  • Unit-tests on Linux / tests-cpu (3.12) / linux-job (gh)
    test/test_transforms.py::TestTimeMaxPool::test_parallel_trans_env_check

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 12, 2024
vmoens added a commit that referenced this pull request Nov 12, 2024
ghstack-source-id: 6bfb32c1e9647bd82cf72424602431da898fd81a
Pull Request resolved: #2553
@vmoens vmoens added enhancement New feature or request performance Performance issue or suggestion for improvement labels Nov 12, 2024
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request performance Performance issue or suggestion for improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants