Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor,CI] Refactor SOTA tests #2583

Merged
merged 15 commits into from
Nov 19, 2024
Merged

[Refactor,CI] Refactor SOTA tests #2583

merged 15 commits into from
Nov 19, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Nov 19, 2024

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Nov 19, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2583

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 20 New Failures, 5 Unrelated Failures

As of commit 6632069 with merge base 408cf7d (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: 3982c3d1a489bd6827fb91c73f259480c78e6974
Pull Request resolved: #2583
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 19, 2024
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: 548f67b041e0a328b0d12baf6e9b84f41aaeae6d
Pull Request resolved: #2583
@vmoens vmoens added Tests Incomplete or broken unit tests CI Has to do with CI setup (e.g. wheels & builds, tests...) Refactoring Refactoring of an existing feature labels Nov 19, 2024
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: 3d0f90fe60570c7d9647d044756ae0923a8c0436
Pull Request resolved: #2583
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: eaf75218bcb9051e738cc7af25092c56099b1af1
Pull Request resolved: #2583
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: 40e03dcdb11d86a575ef78453be5acb82a0f3e93
Pull Request resolved: #2583
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: 5c9dcc90ffcacd11b77aa838a03c9baa221c7188
Pull Request resolved: #2583
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: a0ce79236b8e6564be9fc6c7b7e8f98079befe0b
Pull Request resolved: #2583
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: a0f8c2a6f8d4748fa290d9dc9edd35dcb11074ee
Pull Request resolved: #2583
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: 49343b7018b21bcfc231313ea729bf01d16b4939
Pull Request resolved: #2583
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: b53b829d2615968f5534afa2ff6ea43389b84a4a
Pull Request resolved: #2583
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: 0db78071f1aa03209b383fd4f7abf3d1bc109d17
Pull Request resolved: #2583
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: 0992d119dca3b52f8fa0bfc56edc286bbb81f5a3
Pull Request resolved: #2583
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: 2a17e9bdea19dfe9c7dfd5ab81c461aa605df998
Pull Request resolved: #2583
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: 2a61ba6be24a1714df54dc085dba0cc39024bd47
Pull Request resolved: #2583
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: b14c59bb1ca7bf056bde05fa0abd01fa7e9b3710
Pull Request resolved: #2583
@vmoens vmoens merged commit 6632069 into gh/vmoens/44/base Nov 19, 2024
15 of 24 checks passed
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: b14c59bb1ca7bf056bde05fa0abd01fa7e9b3710
Pull Request resolved: #2583
@vmoens vmoens deleted the gh/vmoens/44/head branch November 19, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Has to do with CI setup (e.g. wheels & builds, tests...) CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Refactoring Refactoring of an existing feature Tests Incomplete or broken unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants