Skip to content

[Lint] pyupgrade #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Mar 3, 2025
Merged

[Lint] pyupgrade #2819

merged 18 commits into from
Mar 3, 2025

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Feb 28, 2025 •
edited
Loading

@vmoens
Update
b8053fe 
[ghstack-poisoned]
This was referenced Feb 3, 2025
Merged
Merged
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2819

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 9 Pending

As of commit 688d12b with merge base 8c9dc05 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Feb 28, 2025
Merged
Merged
Merged
vmoens added a commit that referenced this pull request Feb 28, 2025
@vmoens
[Lint] pyupgrade
cb085bd 
ghstack-source-id: 1057c375cf14cc64bce0dddc73fe62bd3ac682b0
Pull Request resolved: #2819
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 28, 2025
@vmoens
Update
3c1a3c6 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Feb 28, 2025
@vmoens
[Lint] pyupgrade
6cb3b71 
ghstack-source-id: 6d3da4c1a9e5a8bc7c4a64ef37d68dad9e697257
Pull Request resolved: #2819
@vmoens vmoens added the formatting Code formatting changes label Feb 28, 2025
@vmoens
Update
c3707b7 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Feb 28, 2025
@vmoens
[Lint] pyupgrade
244ab98 
ghstack-source-id: 015ce04cccdeac16b8592f4a17377b2649b12c52
Pull Request resolved: #2819
@vmoens
Update
be6c54b 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Feb 28, 2025
@vmoens
[Lint] pyupgrade
4271123 
ghstack-source-id: ee8e8b824af4b94b31caf2e767a8fb522511ee43
Pull Request resolved: #2819
@vmoens
Update
c5b2ad9 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Feb 28, 2025
@vmoens
[Lint] pyupgrade
20dfea0 
ghstack-source-id: 312a8249744ce6a7aafa5afbb460c5f438be4b74
Pull Request resolved: #2819
@vmoens
Update
0e9d5f4 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Feb 28, 2025
@vmoens
[Lint] pyupgrade
b8269d5 
ghstack-source-id: 3488540e19c9652b36a73969ce8a49c41febd94b
Pull Request resolved: #2819
@vmoens
Update
14dbdb2 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Feb 28, 2025
@vmoens
[Lint] pyupgrade
32f088c 
ghstack-source-id: 027a8a8aa28746def4e26bc86e498888b562e2ad
Pull Request resolved: #2819
@vmoens
Update
f6d00ca 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Feb 28, 2025
@vmoens
[Lint] pyupgrade
7f894a5 
ghstack-source-id: ee7f62804c10a43b236274779cbea4c9b1b67e92
Pull Request resolved: #2819
@vmoens
Update
0df5d7b 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Feb 28, 2025
@vmoens
[Lint] pyupgrade
5c327db 
ghstack-source-id: cb4570db1b98055e40df228bdb73e2fadb4738b4
Pull Request resolved: #2819
@vmoens
Update
3bc83f9 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Feb 28, 2025
@vmoens
[Lint] pyupgrade
644686f 
ghstack-source-id: d454b231fc2799f033d1147669c9ebee79e6beae
Pull Request resolved: #2819
@vmoens
Update
2defe3e 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Mar 3, 2025
@vmoens
[Lint] pyupgrade
ef464bc 
ghstack-source-id: 14a1d3d0e203b11bfcaf23401865aabd1932271d
Pull Request resolved: #2819
@vmoens
Update
00b2088 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Mar 3, 2025
@vmoens
[Lint] pyupgrade
384bfbe 
ghstack-source-id: 76f8717a464a69edeaab944e0ffde601640ee5a1
Pull Request resolved: #2819
@vmoens
Update
d7a6812 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Mar 3, 2025
@vmoens
[Lint] pyupgrade
f8a03fc 
ghstack-source-id: 38ddfe2bc1ea284343ce7102a2fbe3154a3ffb7c
Pull Request resolved: #2819
antoinebrl
antoinebrl reviewed Mar 3, 2025
View reviewed changes
test/mocking_classes.py
@@ -133,7 +131,7 @@ def __init__(
def maxstep(self):
return 100

def _set_seed(self, seed: Optional[int]):
def _set_seed(self, seed: int | None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this type notation was introduced in py3.10. Do you still targeting 3.9 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be a from __future__ import annotations in each file - maybe not this one!

@vmoens vmoens added major major refactoring in the code base Environments Adds or modifies an environment wrapper Data Data-related PR, will launch data-related jobs labels Mar 3, 2025
@vmoens
Update
a137732 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Mar 3, 2025
@vmoens
[Lint] pyupgrade
e29cd75 
ghstack-source-id: 2ae01c70f9d901c9d682fddd3fa5ab138499f384
Pull Request resolved: #2819
@vmoens
Update
6bb023d 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Mar 3, 2025
@vmoens
[Lint] pyupgrade
488bb7f 
ghstack-source-id: af1b3f2cc458f166995c4042e03b404e927b38cd
Pull Request resolved: #2819
@vmoens
Update
8512476 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Mar 3, 2025
@vmoens
[Lint] pyupgrade
4192abf 
ghstack-source-id: dd596c6184bb089043964efeb70b91c3f270667c
Pull Request resolved: #2819
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 149. Improved: $\large\color{#35bf28}14$. Worsened: $\large\color{#d91a1a}6$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_simple 0.6465s 0.5456s 1.8329 Ops/s 1.9104 Ops/s $\color{#d91a1a}-4.06\%$
test_transformed 1.1741s 1.0660s 0.9381 Ops/s 0.9416 Ops/s $\color{#d91a1a}-0.37\%$
test_serial 1.6868s 1.5772s 0.6341 Ops/s 0.6281 Ops/s $\color{#35bf28}+0.95\%$
test_parallel 1.4646s 1.3480s 0.7419 Ops/s 0.7313 Ops/s $\color{#35bf28}+1.44\%$
test_step_mdp_speed[True-True-True-True-True] 0.2585ms 30.0919μs 33.2315 KOps/s 31.6611 KOps/s $\color{#35bf28}+4.96\%$
test_step_mdp_speed[True-True-True-True-False] 78.6290μs 17.6684μs 56.5982 KOps/s 55.5785 KOps/s $\color{#35bf28}+1.83\%$
test_step_mdp_speed[True-True-True-False-True] 0.7771ms 17.1144μs 58.4305 KOps/s 57.3839 KOps/s $\color{#35bf28}+1.82\%$
test_step_mdp_speed[True-True-True-False-False] 51.4360μs 10.2114μs 97.9294 KOps/s 98.1574 KOps/s $\color{#d91a1a}-0.23\%$
test_step_mdp_speed[True-True-False-True-True] 75.8310μs 32.7524μs 30.5321 KOps/s 31.1143 KOps/s $\color{#d91a1a}-1.87\%$
test_step_mdp_speed[True-True-False-True-False] 85.2890μs 19.5751μs 51.0854 KOps/s 50.5480 KOps/s $\color{#35bf28}+1.06\%$
test_step_mdp_speed[True-True-False-False-True] 58.1080μs 18.9792μs 52.6892 KOps/s 52.4388 KOps/s $\color{#35bf28}+0.48\%$
test_step_mdp_speed[True-True-False-False-False] 52.4880μs 11.8180μs 84.6167 KOps/s 83.1372 KOps/s $\color{#35bf28}+1.78\%$
test_step_mdp_speed[True-False-True-True-True] 77.7350μs 33.8920μs 29.5055 KOps/s 29.5592 KOps/s $\color{#d91a1a}-0.18\%$
test_step_mdp_speed[True-False-True-True-False] 69.8800μs 21.7072μs 46.0677 KOps/s 45.4879 KOps/s $\color{#35bf28}+1.27\%$
test_step_mdp_speed[True-False-True-False-True] 61.1450μs 19.0122μs 52.5978 KOps/s 52.4145 KOps/s $\color{#35bf28}+0.35\%$
test_step_mdp_speed[True-False-True-False-False] 51.8770μs 12.1276μs 82.4567 KOps/s 82.9080 KOps/s $\color{#d91a1a}-0.54\%$
test_step_mdp_speed[True-False-False-True-True] 83.0750μs 35.7080μs 28.0050 KOps/s 27.7771 KOps/s $\color{#35bf28}+0.82\%$
test_step_mdp_speed[True-False-False-True-False] 62.3670μs 23.8516μs 41.9259 KOps/s 42.4253 KOps/s $\color{#d91a1a}-1.18\%$
test_step_mdp_speed[True-False-False-False-True] 59.5610μs 20.7138μs 48.2770 KOps/s 48.1789 KOps/s $\color{#35bf28}+0.20\%$
test_step_mdp_speed[True-False-False-False-False] 48.8310μs 13.7160μs 72.9077 KOps/s 71.8361 KOps/s $\color{#35bf28}+1.49\%$
test_step_mdp_speed[False-True-True-True-True] 91.2110μs 34.2003μs 29.2395 KOps/s 29.0161 KOps/s $\color{#35bf28}+0.77\%$
test_step_mdp_speed[False-True-True-True-False] 60.3230μs 21.6001μs 46.2960 KOps/s 45.5196 KOps/s $\color{#35bf28}+1.71\%$
test_step_mdp_speed[False-True-True-False-True] 63.5280μs 22.3230μs 44.7968 KOps/s 46.4662 KOps/s $\color{#d91a1a}-3.59\%$
test_step_mdp_speed[False-True-True-False-False] 53.2600μs 13.4830μs 74.1676 KOps/s 74.7433 KOps/s $\color{#d91a1a}-0.77\%$
test_step_mdp_speed[False-True-False-True-True] 78.8070μs 35.5284μs 28.1465 KOps/s 27.8367 KOps/s $\color{#35bf28}+1.11\%$
test_step_mdp_speed[False-True-False-True-False] 0.6031ms 23.3606μs 42.8072 KOps/s 41.9792 KOps/s $\color{#35bf28}+1.97\%$
test_step_mdp_speed[False-True-False-False-True] 2.8174ms 23.6018μs 42.3697 KOps/s 42.4190 KOps/s $\color{#d91a1a}-0.12\%$
test_step_mdp_speed[False-True-False-False-False] 58.6990μs 15.4162μs 64.8668 KOps/s 66.6423 KOps/s $\color{#d91a1a}-2.66\%$
test_step_mdp_speed[False-False-True-True-True] 86.2310μs 37.5535μs 26.6287 KOps/s 26.5252 KOps/s $\color{#35bf28}+0.39\%$
test_step_mdp_speed[False-False-True-True-False] 72.7960μs 25.9268μs 38.5701 KOps/s 39.5115 KOps/s $\color{#d91a1a}-2.38\%$
test_step_mdp_speed[False-False-True-False-True] 86.0100μs 23.6102μs 42.3546 KOps/s 42.9671 KOps/s $\color{#d91a1a}-1.43\%$
test_step_mdp_speed[False-False-True-False-False] 56.6360μs 15.3484μs 65.1534 KOps/s 66.3924 KOps/s $\color{#d91a1a}-1.87\%$
test_step_mdp_speed[False-False-False-True-True] 83.1750μs 38.9705μs 25.6604 KOps/s 25.5200 KOps/s $\color{#35bf28}+0.55\%$
test_step_mdp_speed[False-False-False-True-False] 66.8750μs 26.9625μs 37.0886 KOps/s 36.8828 KOps/s $\color{#35bf28}+0.56\%$
test_step_mdp_speed[False-False-False-False-True] 72.1450μs 25.4933μs 39.2261 KOps/s 38.6845 KOps/s $\color{#35bf28}+1.40\%$
test_step_mdp_speed[False-False-False-False-False] 55.0020μs 16.9976μs 58.8318 KOps/s 58.9770 KOps/s $\color{#d91a1a}-0.25\%$
test_values[generalized_advantage_estimate-True-True] 10.6366ms 10.0592ms 99.4110 Ops/s 103.6180 Ops/s $\color{#d91a1a}-4.06\%$
test_values[vec_generalized_advantage_estimate-True-True] 26.2741ms 24.4155ms 40.9577 Ops/s 40.9037 Ops/s $\color{#35bf28}+0.13\%$
test_values[td0_return_estimate-False-False] 0.2892ms 0.2088ms 4.7892 KOps/s 5.0833 KOps/s $\textbf{\color{#d91a1a}-5.79\%}$
test_values[td1_return_estimate-False-False] 28.9711ms 25.5601ms 39.1235 Ops/s 40.7265 Ops/s $\color{#d91a1a}-3.94\%$
test_values[vec_td1_return_estimate-False-False] 27.5740ms 24.6300ms 40.6010 Ops/s 40.8868 Ops/s $\color{#d91a1a}-0.70\%$
test_values[td_lambda_return_estimate-True-False] 39.5070ms 36.2637ms 27.5758 Ops/s 28.5884 Ops/s $\color{#d91a1a}-3.54\%$
test_values[vec_td_lambda_return_estimate-True-False] 26.5259ms 24.5254ms 40.7740 Ops/s 40.6990 Ops/s $\color{#35bf28}+0.18\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 9.1612ms 8.6152ms 116.0737 Ops/s 117.3722 Ops/s $\color{#d91a1a}-1.11\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.1195ms 1.7550ms 569.8001 Ops/s 513.8992 Ops/s $\textbf{\color{#35bf28}+10.88\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5982ms 0.3741ms 2.6730 KOps/s 2.6867 KOps/s $\color{#d91a1a}-0.51\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 37.4641ms 36.2621ms 27.5770 Ops/s 24.0548 Ops/s $\textbf{\color{#35bf28}+14.64\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.3809ms 3.5035ms 285.4297 Ops/s 285.8281 Ops/s $\color{#d91a1a}-0.14\%$
test_dqn_speed[False-None] 1.7974ms 1.4214ms 703.5372 Ops/s 707.3574 Ops/s $\color{#d91a1a}-0.54\%$
test_dqn_speed[False-backward] 2.0825ms 1.9349ms 516.8193 Ops/s 527.2348 Ops/s $\color{#d91a1a}-1.98\%$
test_dqn_speed[True-None] 0.7536ms 0.4784ms 2.0903 KOps/s 2.0422 KOps/s $\color{#35bf28}+2.36\%$
test_dqn_speed[True-backward] 1.1269ms 0.9551ms 1.0470 KOps/s 1.0011 KOps/s $\color{#35bf28}+4.58\%$
test_dqn_speed[reduce-overhead-None] 0.7322ms 0.4795ms 2.0857 KOps/s 2.0241 KOps/s $\color{#35bf28}+3.04\%$
test_dqn_speed[reduce-overhead-backward] 1.0152ms 0.9193ms 1.0878 KOps/s 1.0712 KOps/s $\color{#35bf28}+1.54\%$
test_ddpg_speed[False-None] 3.5081ms 2.9483ms 339.1764 Ops/s 337.4758 Ops/s $\color{#35bf28}+0.50\%$
test_ddpg_speed[False-backward] 5.4014ms 4.1640ms 240.1565 Ops/s 230.8852 Ops/s $\color{#35bf28}+4.02\%$
test_ddpg_speed[True-None] 1.5709ms 1.2442ms 803.7012 Ops/s 790.9633 Ops/s $\color{#35bf28}+1.61\%$
test_ddpg_speed[True-backward] 2.3596ms 2.2237ms 449.6965 Ops/s 456.0687 Ops/s $\color{#d91a1a}-1.40\%$
test_ddpg_speed[reduce-overhead-None] 1.7103ms 1.2372ms 808.2776 Ops/s 790.9055 Ops/s $\color{#35bf28}+2.20\%$
test_ddpg_speed[reduce-overhead-backward] 2.4032ms 2.2247ms 449.4973 Ops/s 455.2453 Ops/s $\color{#d91a1a}-1.26\%$
test_sac_speed[False-None] 11.1794ms 8.4684ms 118.0856 Ops/s 115.2153 Ops/s $\color{#35bf28}+2.49\%$
test_sac_speed[False-backward] 12.5410ms 11.3554ms 88.0641 Ops/s 84.9654 Ops/s $\color{#35bf28}+3.65\%$
test_sac_speed[True-None] 2.7423ms 2.1110ms 473.7109 Ops/s 455.9359 Ops/s $\color{#35bf28}+3.90\%$
test_sac_speed[True-backward] 4.3641ms 3.9692ms 251.9381 Ops/s 257.1145 Ops/s $\color{#d91a1a}-2.01\%$
test_sac_speed[reduce-overhead-None] 2.6751ms 2.1703ms 460.7728 Ops/s 434.8963 Ops/s $\textbf{\color{#35bf28}+5.95\%}$
test_sac_speed[reduce-overhead-backward] 4.8050ms 4.2098ms 237.5387 Ops/s 245.2765 Ops/s $\color{#d91a1a}-3.15\%$
test_redq_speed[False-None] 14.5354ms 13.3693ms 74.7983 Ops/s 72.6839 Ops/s $\color{#35bf28}+2.91\%$
test_redq_speed[False-backward] 24.1291ms 22.8802ms 43.7059 Ops/s 42.8828 Ops/s $\color{#35bf28}+1.92\%$
test_redq_speed[True-None] 6.7324ms 5.7127ms 175.0476 Ops/s 182.5123 Ops/s $\color{#d91a1a}-4.09\%$
test_redq_speed[True-backward] 14.2949ms 13.5166ms 73.9831 Ops/s 74.3829 Ops/s $\color{#d91a1a}-0.54\%$
test_redq_speed[reduce-overhead-None] 6.9311ms 5.3080ms 188.3948 Ops/s 180.1715 Ops/s $\color{#35bf28}+4.56\%$
test_redq_speed[reduce-overhead-backward] 14.0948ms 13.3473ms 74.9216 Ops/s 74.4878 Ops/s $\color{#35bf28}+0.58\%$
test_redq_deprec_speed[False-None] 16.0672ms 13.9043ms 71.9200 Ops/s 72.8162 Ops/s $\color{#d91a1a}-1.23\%$
test_redq_deprec_speed[False-backward] 21.9600ms 20.2144ms 49.4698 Ops/s 50.7688 Ops/s $\color{#d91a1a}-2.56\%$
test_redq_deprec_speed[True-None] 5.3815ms 4.5073ms 221.8647 Ops/s 242.4251 Ops/s $\textbf{\color{#d91a1a}-8.48\%}$
test_redq_deprec_speed[True-backward] 10.2630ms 9.6462ms 103.6682 Ops/s 107.7792 Ops/s $\color{#d91a1a}-3.81\%$
test_redq_deprec_speed[reduce-overhead-None] 5.7119ms 4.7018ms 212.6854 Ops/s 206.6378 Ops/s $\color{#35bf28}+2.93\%$
test_redq_deprec_speed[reduce-overhead-backward] 10.3750ms 9.6784ms 103.3229 Ops/s 112.3185 Ops/s $\textbf{\color{#d91a1a}-8.01\%}$
test_td3_speed[False-None] 9.0349ms 8.5663ms 116.7361 Ops/s 115.2271 Ops/s $\color{#35bf28}+1.31\%$
test_td3_speed[False-backward] 11.3044ms 10.7274ms 93.2191 Ops/s 88.1539 Ops/s $\textbf{\color{#35bf28}+5.75\%}$
test_td3_speed[True-None] 2.0317ms 1.8150ms 550.9783 Ops/s 533.9595 Ops/s $\color{#35bf28}+3.19\%$
test_td3_speed[True-backward] 3.9645ms 3.5995ms 277.8141 Ops/s 260.9287 Ops/s $\textbf{\color{#35bf28}+6.47\%}$
test_td3_speed[reduce-overhead-None] 1.9702ms 1.7999ms 555.6017 Ops/s 540.5292 Ops/s $\color{#35bf28}+2.79\%$
test_td3_speed[reduce-overhead-backward] 4.1201ms 3.6190ms 276.3159 Ops/s 259.7229 Ops/s $\textbf{\color{#35bf28}+6.39\%}$
test_cql_speed[False-None] 39.3164ms 36.7456ms 27.2141 Ops/s 26.0087 Ops/s $\color{#35bf28}+4.63\%$
test_cql_speed[False-backward] 55.5761ms 49.1847ms 20.3315 Ops/s 20.3877 Ops/s $\color{#d91a1a}-0.28\%$
test_cql_speed[True-None] 17.4606ms 16.2633ms 61.4883 Ops/s 58.1678 Ops/s $\textbf{\color{#35bf28}+5.71\%}$
test_cql_speed[True-backward] 24.5446ms 23.4767ms 42.5954 Ops/s 41.1537 Ops/s $\color{#35bf28}+3.50\%$
test_cql_speed[reduce-overhead-None] 17.5667ms 16.4927ms 60.6329 Ops/s 58.8841 Ops/s $\color{#35bf28}+2.97\%$
test_cql_speed[reduce-overhead-backward] 24.4966ms 23.5739ms 42.4198 Ops/s 40.9691 Ops/s $\color{#35bf28}+3.54\%$
test_a2c_speed[False-None] 8.0794ms 7.4773ms 133.7381 Ops/s 127.8468 Ops/s $\color{#35bf28}+4.61\%$
test_a2c_speed[False-backward] 15.7916ms 14.9623ms 66.8349 Ops/s 64.8054 Ops/s $\color{#35bf28}+3.13\%$
test_a2c_speed[True-None] 4.8362ms 3.8682ms 258.5154 Ops/s 248.2286 Ops/s $\color{#35bf28}+4.14\%$
test_a2c_speed[True-backward] 12.4511ms 11.0859ms 90.2045 Ops/s 94.5005 Ops/s $\color{#d91a1a}-4.55\%$
test_a2c_speed[reduce-overhead-None] 4.5693ms 4.0652ms 245.9927 Ops/s 255.1943 Ops/s $\color{#d91a1a}-3.61\%$
test_a2c_speed[reduce-overhead-backward] 11.3624ms 10.8305ms 92.3317 Ops/s 90.2326 Ops/s $\color{#35bf28}+2.33\%$
test_ppo_speed[False-None] 9.2904ms 7.9002ms 126.5794 Ops/s 123.8459 Ops/s $\color{#35bf28}+2.21\%$
test_ppo_speed[False-backward] 17.1526ms 15.4746ms 64.6221 Ops/s 62.3396 Ops/s $\color{#35bf28}+3.66\%$
test_ppo_speed[True-None] 5.0593ms 4.2329ms 236.2447 Ops/s 230.7788 Ops/s $\color{#35bf28}+2.37\%$
test_ppo_speed[True-backward] 11.2974ms 10.2838ms 97.2408 Ops/s 88.6609 Ops/s $\textbf{\color{#35bf28}+9.68\%}$
test_ppo_speed[reduce-overhead-None] 5.2742ms 4.4054ms 226.9962 Ops/s 218.0356 Ops/s $\color{#35bf28}+4.11\%$
test_ppo_speed[reduce-overhead-backward] 11.7827ms 10.7308ms 93.1896 Ops/s 91.0086 Ops/s $\color{#35bf28}+2.40\%$
test_reinforce_speed[False-None] 7.4770ms 6.7637ms 147.8471 Ops/s 144.3447 Ops/s $\color{#35bf28}+2.43\%$
test_reinforce_speed[False-backward] 11.6948ms 10.4592ms 95.6094 Ops/s 97.7664 Ops/s $\color{#d91a1a}-2.21\%$
test_reinforce_speed[True-None] 4.2496ms 3.3840ms 295.5089 Ops/s 283.9128 Ops/s $\color{#35bf28}+4.08\%$
test_reinforce_speed[True-backward] 10.8576ms 9.7951ms 102.0923 Ops/s 97.9693 Ops/s $\color{#35bf28}+4.21\%$
test_reinforce_speed[reduce-overhead-None] 4.2699ms 3.5272ms 283.5091 Ops/s 288.5413 Ops/s $\color{#d91a1a}-1.74\%$
test_reinforce_speed[reduce-overhead-backward] 10.9089ms 9.8442ms 101.5827 Ops/s 98.7218 Ops/s $\color{#35bf28}+2.90\%$
test_iql_speed[False-None] 34.8150ms 33.3794ms 29.9586 Ops/s 28.5216 Ops/s $\textbf{\color{#35bf28}+5.04\%}$
test_iql_speed[False-backward] 54.1819ms 46.9652ms 21.2924 Ops/s 20.7028 Ops/s $\color{#35bf28}+2.85\%$
test_iql_speed[True-None] 12.8549ms 11.8289ms 84.5389 Ops/s 82.3765 Ops/s $\color{#35bf28}+2.63\%$
test_iql_speed[True-backward] 24.5256ms 23.7036ms 42.1876 Ops/s 42.0399 Ops/s $\color{#35bf28}+0.35\%$
test_iql_speed[reduce-overhead-None] 12.5593ms 11.9011ms 84.0257 Ops/s 82.1351 Ops/s $\color{#35bf28}+2.30\%$
test_iql_speed[reduce-overhead-backward] 24.2892ms 23.4190ms 42.7004 Ops/s 42.0731 Ops/s $\color{#35bf28}+1.49\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.0525ms 5.1378ms 194.6359 Ops/s 188.5689 Ops/s $\color{#35bf28}+3.22\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 2.6234ms 0.5552ms 1.8012 KOps/s 1.7832 KOps/s $\color{#35bf28}+1.01\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 1.0708ms 0.5253ms 1.9035 KOps/s 1.8774 KOps/s $\color{#35bf28}+1.39\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.3854ms 4.8805ms 204.8971 Ops/s 192.3610 Ops/s $\textbf{\color{#35bf28}+6.52\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.7978ms 0.5418ms 1.8456 KOps/s 1.7800 KOps/s $\color{#35bf28}+3.68\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.9242ms 0.5194ms 1.9253 KOps/s 1.8641 KOps/s $\color{#35bf28}+3.28\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.7806ms 1.7329ms 577.0636 Ops/s 569.5705 Ops/s $\color{#35bf28}+1.32\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.4070ms 1.6499ms 606.1086 Ops/s 601.5696 Ops/s $\color{#35bf28}+0.75\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.2126ms 4.9889ms 200.4462 Ops/s 187.5758 Ops/s $\textbf{\color{#35bf28}+6.86\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.3519ms 0.6937ms 1.4415 KOps/s 1.3930 KOps/s $\color{#35bf28}+3.48\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.0600ms 0.6736ms 1.4846 KOps/s 1.4689 KOps/s $\color{#35bf28}+1.07\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.1899ms 4.8688ms 205.3898 Ops/s 190.9384 Ops/s $\textbf{\color{#35bf28}+7.57\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 2.5399ms 0.5557ms 1.7994 KOps/s 1.7745 KOps/s $\color{#35bf28}+1.40\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 1.0291ms 0.5270ms 1.8976 KOps/s 1.8325 KOps/s $\color{#35bf28}+3.55\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.1856ms 4.7901ms 208.7626 Ops/s 199.1232 Ops/s $\color{#35bf28}+4.84\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.6788ms 0.5405ms 1.8502 KOps/s 1.7657 KOps/s $\color{#35bf28}+4.79\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.8787ms 0.5190ms 1.9266 KOps/s 1.9212 KOps/s $\color{#35bf28}+0.28\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.7774ms 4.9834ms 200.6660 Ops/s 196.8060 Ops/s $\color{#35bf28}+1.96\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.6252ms 0.6981ms 1.4326 KOps/s 1.3950 KOps/s $\color{#35bf28}+2.69\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.0613ms 0.6791ms 1.4725 KOps/s 1.4903 KOps/s $\color{#d91a1a}-1.20\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.5013s 14.3232ms 69.8167 Ops/s 240.6195 Ops/s $\textbf{\color{#d91a1a}-70.98\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 7.8028ms 2.3517ms 425.2315 Ops/s 420.1419 Ops/s $\color{#35bf28}+1.21\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 6.3408ms 1.3964ms 716.1273 Ops/s 692.2266 Ops/s $\color{#35bf28}+3.45\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 6.6135ms 4.4841ms 223.0120 Ops/s 237.8167 Ops/s $\textbf{\color{#d91a1a}-6.23\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 6.8122ms 2.4085ms 415.1916 Ops/s 360.4593 Ops/s $\textbf{\color{#35bf28}+15.18\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 5.0111ms 1.3978ms 715.3919 Ops/s 693.3714 Ops/s $\color{#35bf28}+3.18\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 8.7471ms 4.6208ms 216.4123 Ops/s 29.0831 Ops/s $\textbf{\color{#35bf28}+644.12\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.5231s 12.9603ms 77.1585 Ops/s 378.6701 Ops/s $\textbf{\color{#d91a1a}-79.62\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 4.0209ms 1.5121ms 661.3245 Ops/s 643.5361 Ops/s $\color{#35bf28}+2.76\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 14.4669ms 12.7523ms 78.4174 Ops/s 79.4029 Ops/s $\color{#d91a1a}-1.24\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 16.0434ms 14.6654ms 68.1879 Ops/s 68.4048 Ops/s $\color{#d91a1a}-0.32\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 21.8388ms 21.4792ms 46.5567 Ops/s 46.7143 Ops/s $\color{#d91a1a}-0.34\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 16.1761ms 14.9438ms 66.9174 Ops/s 67.8054 Ops/s $\color{#d91a1a}-1.31\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 23.3562ms 21.5356ms 46.4348 Ops/s 46.7761 Ops/s $\color{#d91a1a}-0.73\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 21.3258ms 16.3136ms 61.2985 Ops/s 62.3490 Ops/s $\color{#d91a1a}-1.68\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 149. Improved: $\large\color{#35bf28}25$. Worsened: $\large\color{#d91a1a}7$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_simple 0.9035s 0.8171s 1.2238 Ops/s 1.2582 Ops/s $\color{#d91a1a}-2.74\%$
test_transformed 1.5095s 1.4212s 0.7036 Ops/s 0.7126 Ops/s $\color{#d91a1a}-1.25\%$
test_serial 2.3962s 2.3032s 0.4342 Ops/s 0.4341 Ops/s $\color{#35bf28}+0.01\%$
test_parallel 1.9525s 1.8595s 0.5378 Ops/s 0.5319 Ops/s $\color{#35bf28}+1.12\%$
test_step_mdp_speed[True-True-True-True-True] 0.2167ms 40.4630μs 24.7139 KOps/s 24.5732 KOps/s $\color{#35bf28}+0.57\%$
test_step_mdp_speed[True-True-True-True-False] 0.1477ms 23.4107μs 42.7155 KOps/s 43.2210 KOps/s $\color{#d91a1a}-1.17\%$
test_step_mdp_speed[True-True-True-False-True] 68.5700μs 22.3227μs 44.7975 KOps/s 44.6696 KOps/s $\color{#35bf28}+0.29\%$
test_step_mdp_speed[True-True-True-False-False] 49.1910μs 12.8301μs 77.9416 KOps/s 76.8763 KOps/s $\color{#35bf28}+1.39\%$
test_step_mdp_speed[True-True-False-True-True] 0.1276ms 42.7147μs 23.4111 KOps/s 23.8081 KOps/s $\color{#d91a1a}-1.67\%$
test_step_mdp_speed[True-True-False-True-False] 74.0400μs 25.6997μs 38.9110 KOps/s 38.8745 KOps/s $\color{#35bf28}+0.09\%$
test_step_mdp_speed[True-True-False-False-True] 51.5200μs 24.9661μs 40.0542 KOps/s 40.8993 KOps/s $\color{#d91a1a}-2.07\%$
test_step_mdp_speed[True-True-False-False-False] 93.8910μs 15.2980μs 65.3681 KOps/s 65.2636 KOps/s $\color{#35bf28}+0.16\%$
test_step_mdp_speed[True-False-True-True-True] 0.1049ms 45.6761μs 21.8933 KOps/s 22.8355 KOps/s $\color{#d91a1a}-4.13\%$
test_step_mdp_speed[True-False-True-True-False] 57.6500μs 28.2769μs 35.3646 KOps/s 35.9819 KOps/s $\color{#d91a1a}-1.72\%$
test_step_mdp_speed[True-False-True-False-True] 52.9910μs 24.5829μs 40.6787 KOps/s 40.9559 KOps/s $\color{#d91a1a}-0.68\%$
test_step_mdp_speed[True-False-True-False-False] 46.4910μs 15.2851μs 65.4231 KOps/s 65.9518 KOps/s $\color{#d91a1a}-0.80\%$
test_step_mdp_speed[True-False-False-True-True] 0.1470ms 46.9534μs 21.2977 KOps/s 21.5366 KOps/s $\color{#d91a1a}-1.11\%$
test_step_mdp_speed[True-False-False-True-False] 57.1910μs 30.5204μs 32.7650 KOps/s 33.7191 KOps/s $\color{#d91a1a}-2.83\%$
test_step_mdp_speed[True-False-False-False-True] 52.9000μs 26.9587μs 37.0938 KOps/s 37.4119 KOps/s $\color{#d91a1a}-0.85\%$
test_step_mdp_speed[True-False-False-False-False] 50.1510μs 17.7885μs 56.2161 KOps/s 57.0087 KOps/s $\color{#d91a1a}-1.39\%$
test_step_mdp_speed[False-True-True-True-True] 0.1100ms 45.1305μs 22.1580 KOps/s 22.2909 KOps/s $\color{#d91a1a}-0.60\%$
test_step_mdp_speed[False-True-True-True-False] 85.2510μs 28.1611μs 35.5099 KOps/s 35.6807 KOps/s $\color{#d91a1a}-0.48\%$
test_step_mdp_speed[False-True-True-False-True] 56.7310μs 28.5436μs 35.0341 KOps/s 34.9113 KOps/s $\color{#35bf28}+0.35\%$
test_step_mdp_speed[False-True-True-False-False] 58.5810μs 17.2486μs 57.9757 KOps/s 58.5674 KOps/s $\color{#d91a1a}-1.01\%$
test_step_mdp_speed[False-True-False-True-True] 0.2485ms 47.7734μs 20.9322 KOps/s 20.9859 KOps/s $\color{#d91a1a}-0.26\%$
test_step_mdp_speed[False-True-False-True-False] 0.1478ms 30.6900μs 32.5840 KOps/s 32.8576 KOps/s $\color{#d91a1a}-0.83\%$
test_step_mdp_speed[False-True-False-False-True] 3.3265ms 31.4092μs 31.8378 KOps/s 32.0656 KOps/s $\color{#d91a1a}-0.71\%$
test_step_mdp_speed[False-True-False-False-False] 95.2910μs 19.4728μs 51.3536 KOps/s 51.9956 KOps/s $\color{#d91a1a}-1.23\%$
test_step_mdp_speed[False-False-True-True-True] 76.8710μs 49.5443μs 20.1840 KOps/s 20.3447 KOps/s $\color{#d91a1a}-0.79\%$
test_step_mdp_speed[False-False-True-True-False] 68.2900μs 32.7350μs 30.5483 KOps/s 30.1804 KOps/s $\color{#35bf28}+1.22\%$
test_step_mdp_speed[False-False-True-False-True] 60.8510μs 30.3304μs 32.9702 KOps/s 32.0141 KOps/s $\color{#35bf28}+2.99\%$
test_step_mdp_speed[False-False-True-False-False] 0.1300ms 19.0139μs 52.5931 KOps/s 51.8511 KOps/s $\color{#35bf28}+1.43\%$
test_step_mdp_speed[False-False-False-True-True] 82.4710μs 51.1265μs 19.5593 KOps/s 19.6286 KOps/s $\color{#d91a1a}-0.35\%$
test_step_mdp_speed[False-False-False-True-False] 62.9200μs 35.2020μs 28.4074 KOps/s 28.6434 KOps/s $\color{#d91a1a}-0.82\%$
test_step_mdp_speed[False-False-False-False-True] 57.4600μs 32.2582μs 30.9998 KOps/s 30.4769 KOps/s $\color{#35bf28}+1.72\%$
test_step_mdp_speed[False-False-False-False-False] 0.1540ms 21.6226μs 46.2478 KOps/s 47.4427 KOps/s $\color{#d91a1a}-2.52\%$
test_values[generalized_advantage_estimate-True-True] 25.7202ms 25.3347ms 39.4715 Ops/s 39.5427 Ops/s $\color{#d91a1a}-0.18\%$
test_values[vec_generalized_advantage_estimate-True-True] 0.1103s 3.1108ms 321.4630 Ops/s 316.7911 Ops/s $\color{#35bf28}+1.47\%$
test_values[td0_return_estimate-False-False] 0.1036ms 81.4672μs 12.2749 KOps/s 12.3926 KOps/s $\color{#d91a1a}-0.95\%$
test_values[td1_return_estimate-False-False] 60.3727ms 57.0500ms 17.5285 Ops/s 17.7577 Ops/s $\color{#d91a1a}-1.29\%$
test_values[vec_td1_return_estimate-False-False] 1.2648ms 1.0910ms 916.5543 Ops/s 915.9724 Ops/s $\color{#35bf28}+0.06\%$
test_values[td_lambda_return_estimate-True-False] 94.7655ms 90.9444ms 10.9957 Ops/s 11.2412 Ops/s $\color{#d91a1a}-2.18\%$
test_values[vec_td_lambda_return_estimate-True-False] 1.2875ms 1.0846ms 921.9866 Ops/s 918.4614 Ops/s $\color{#35bf28}+0.38\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 27.3591ms 26.9286ms 37.1352 Ops/s 40.1601 Ops/s $\textbf{\color{#d91a1a}-7.53\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.0381ms 0.7655ms 1.3063 KOps/s 1.3211 KOps/s $\color{#d91a1a}-1.12\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.8338ms 0.6707ms 1.4910 KOps/s 1.4762 KOps/s $\color{#35bf28}+1.00\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.6581ms 1.4948ms 668.9699 Ops/s 670.0010 Ops/s $\color{#d91a1a}-0.15\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.8954ms 0.7211ms 1.3868 KOps/s 1.4585 KOps/s $\color{#d91a1a}-4.92\%$
test_dqn_speed[False-None] 1.6712ms 1.5061ms 663.9546 Ops/s 668.5779 Ops/s $\color{#d91a1a}-0.69\%$
test_dqn_speed[False-backward] 2.2791ms 2.1279ms 469.9372 Ops/s 474.6338 Ops/s $\color{#d91a1a}-0.99\%$
test_dqn_speed[True-None] 0.9758ms 0.5509ms 1.8151 KOps/s 1.7037 KOps/s $\textbf{\color{#35bf28}+6.54\%}$
test_dqn_speed[True-backward] 1.2536ms 1.1197ms 893.1025 Ops/s 787.7905 Ops/s $\textbf{\color{#35bf28}+13.37\%}$
test_dqn_speed[reduce-overhead-None] 0.7628ms 0.5701ms 1.7541 KOps/s 1.6878 KOps/s $\color{#35bf28}+3.93\%$
test_dqn_speed[reduce-overhead-backward] 0.9968ms 0.9587ms 1.0430 KOps/s 919.6136 Ops/s $\textbf{\color{#35bf28}+13.42\%}$
test_ddpg_speed[False-None] 3.2167ms 2.7940ms 357.9072 Ops/s 356.7763 Ops/s $\color{#35bf28}+0.32\%$
test_ddpg_speed[False-backward] 4.2554ms 4.0418ms 247.4131 Ops/s 239.2154 Ops/s $\color{#35bf28}+3.43\%$
test_ddpg_speed[True-None] 1.7102ms 1.3414ms 745.4964 Ops/s 738.5076 Ops/s $\color{#35bf28}+0.95\%$
test_ddpg_speed[True-backward] 2.5758ms 2.4370ms 410.3381 Ops/s 378.0926 Ops/s $\textbf{\color{#35bf28}+8.53\%}$
test_ddpg_speed[reduce-overhead-None] 1.7545ms 1.3569ms 736.9936 Ops/s 734.2663 Ops/s $\color{#35bf28}+0.37\%$
test_ddpg_speed[reduce-overhead-backward] 2.1132ms 1.8995ms 526.4529 Ops/s 486.0842 Ops/s $\textbf{\color{#35bf28}+8.30\%}$
test_sac_speed[False-None] 8.4699ms 8.0389ms 124.3949 Ops/s 124.0379 Ops/s $\color{#35bf28}+0.29\%$
test_sac_speed[False-backward] 11.5282ms 10.9613ms 91.2303 Ops/s 88.2775 Ops/s $\color{#35bf28}+3.34\%$
test_sac_speed[True-None] 2.0975ms 1.8480ms 541.1141 Ops/s 536.8521 Ops/s $\color{#35bf28}+0.79\%$
test_sac_speed[True-backward] 3.8548ms 3.6187ms 276.3457 Ops/s 275.1005 Ops/s $\color{#35bf28}+0.45\%$
test_sac_speed[reduce-overhead-None] 21.0837ms 11.9755ms 83.5035 Ops/s 84.3683 Ops/s $\color{#d91a1a}-1.03\%$
test_sac_speed[reduce-overhead-backward] 1.8332ms 1.6129ms 620.0155 Ops/s 571.9754 Ops/s $\textbf{\color{#35bf28}+8.40\%}$
test_redq_speed[False-None] 8.1645ms 7.6040ms 131.5093 Ops/s 130.1525 Ops/s $\color{#35bf28}+1.04\%$
test_redq_speed[False-backward] 12.0561ms 11.4760ms 87.1386 Ops/s 85.3320 Ops/s $\color{#35bf28}+2.12\%$
test_redq_speed[True-None] 2.5207ms 2.3386ms 427.6115 Ops/s 424.5894 Ops/s $\color{#35bf28}+0.71\%$
test_redq_speed[True-backward] 4.5258ms 4.0746ms 245.4219 Ops/s 233.0977 Ops/s $\textbf{\color{#35bf28}+5.29\%}$
test_redq_speed[reduce-overhead-None] 2.6888ms 2.3661ms 422.6350 Ops/s 421.3238 Ops/s $\color{#35bf28}+0.31\%$
test_redq_speed[reduce-overhead-backward] 4.4909ms 4.0721ms 245.5743 Ops/s 230.3933 Ops/s $\textbf{\color{#35bf28}+6.59\%}$
test_redq_deprec_speed[False-None] 9.4986ms 9.0097ms 110.9915 Ops/s 109.8705 Ops/s $\color{#35bf28}+1.02\%$
test_redq_deprec_speed[False-backward] 12.3703ms 12.0230ms 83.1740 Ops/s 81.1575 Ops/s $\color{#35bf28}+2.48\%$
test_redq_deprec_speed[True-None] 3.0203ms 2.6534ms 376.8818 Ops/s 374.6661 Ops/s $\color{#35bf28}+0.59\%$
test_redq_deprec_speed[True-backward] 4.4717ms 4.3126ms 231.8763 Ops/s 218.1865 Ops/s $\textbf{\color{#35bf28}+6.27\%}$
test_redq_deprec_speed[reduce-overhead-None] 3.0670ms 2.6453ms 378.0268 Ops/s 358.6876 Ops/s $\textbf{\color{#35bf28}+5.39\%}$
test_redq_deprec_speed[reduce-overhead-backward] 4.5005ms 4.3144ms 231.7812 Ops/s 214.1047 Ops/s $\textbf{\color{#35bf28}+8.26\%}$
test_td3_speed[False-None] 8.0180ms 7.9395ms 125.9523 Ops/s 124.0349 Ops/s $\color{#35bf28}+1.55\%$
test_td3_speed[False-backward] 11.0543ms 10.2762ms 97.3123 Ops/s 95.6725 Ops/s $\color{#35bf28}+1.71\%$
test_td3_speed[True-None] 1.6971ms 1.6401ms 609.7172 Ops/s 596.1754 Ops/s $\color{#35bf28}+2.27\%$
test_td3_speed[True-backward] 3.5435ms 3.3360ms 299.7639 Ops/s 304.2884 Ops/s $\color{#d91a1a}-1.49\%$
test_td3_speed[reduce-overhead-None] 51.0940ms 26.0414ms 38.4004 Ops/s 37.7353 Ops/s $\color{#35bf28}+1.76\%$
test_td3_speed[reduce-overhead-backward] 1.6209ms 1.4036ms 712.4304 Ops/s 654.9880 Ops/s $\textbf{\color{#35bf28}+8.77\%}$
test_cql_speed[False-None] 17.2088ms 16.6925ms 59.9073 Ops/s 59.7785 Ops/s $\color{#35bf28}+0.22\%$
test_cql_speed[False-backward] 22.3025ms 21.8360ms 45.7959 Ops/s 45.0208 Ops/s $\color{#35bf28}+1.72\%$
test_cql_speed[True-None] 3.5705ms 3.3019ms 302.8521 Ops/s 294.3876 Ops/s $\color{#35bf28}+2.88\%$
test_cql_speed[True-backward] 5.9371ms 5.5426ms 180.4218 Ops/s 174.4284 Ops/s $\color{#35bf28}+3.44\%$
test_cql_speed[reduce-overhead-None] 21.3495ms 13.1590ms 75.9936 Ops/s 76.0511 Ops/s $\color{#d91a1a}-0.08\%$
test_cql_speed[reduce-overhead-backward] 1.9467ms 1.8057ms 553.8091 Ops/s 494.6604 Ops/s $\textbf{\color{#35bf28}+11.96\%}$
test_a2c_speed[False-None] 3.3116ms 3.1353ms 318.9483 Ops/s 316.2161 Ops/s $\color{#35bf28}+0.86\%$
test_a2c_speed[False-backward] 6.5860ms 6.0491ms 165.3139 Ops/s 157.0303 Ops/s $\textbf{\color{#35bf28}+5.28\%}$
test_a2c_speed[True-None] 1.5173ms 1.3479ms 741.8864 Ops/s 725.1500 Ops/s $\color{#35bf28}+2.31\%$
test_a2c_speed[True-backward] 3.0857ms 2.9233ms 342.0798 Ops/s 335.2212 Ops/s $\color{#35bf28}+2.05\%$
test_a2c_speed[reduce-overhead-None] 15.8482ms 8.9312ms 111.9673 Ops/s 115.1219 Ops/s $\color{#d91a1a}-2.74\%$
test_a2c_speed[reduce-overhead-backward] 1.6583ms 1.4651ms 682.5320 Ops/s 671.1408 Ops/s $\color{#35bf28}+1.70\%$
test_ppo_speed[False-None] 3.8363ms 3.6319ms 275.3401 Ops/s 272.5067 Ops/s $\color{#35bf28}+1.04\%$
test_ppo_speed[False-backward] 7.0918ms 6.7400ms 148.3677 Ops/s 145.2839 Ops/s $\color{#35bf28}+2.12\%$
test_ppo_speed[True-None] 1.5906ms 1.4247ms 701.9178 Ops/s 688.6560 Ops/s $\color{#35bf28}+1.93\%$
test_ppo_speed[True-backward] 3.4068ms 3.2183ms 310.7205 Ops/s 303.4973 Ops/s $\color{#35bf28}+2.38\%$
test_ppo_speed[reduce-overhead-None] 1.1370ms 0.9676ms 1.0334 KOps/s 1.0369 KOps/s $\color{#d91a1a}-0.34\%$
test_ppo_speed[reduce-overhead-backward] 1.5353ms 1.4166ms 705.9321 Ops/s 611.3809 Ops/s $\textbf{\color{#35bf28}+15.47\%}$
test_reinforce_speed[False-None] 2.4568ms 2.2306ms 448.3036 Ops/s 425.3450 Ops/s $\textbf{\color{#35bf28}+5.40\%}$
test_reinforce_speed[False-backward] 3.6765ms 3.2533ms 307.3803 Ops/s 297.8200 Ops/s $\color{#35bf28}+3.21\%$
test_reinforce_speed[True-None] 1.4528ms 1.2929ms 773.4306 Ops/s 759.6443 Ops/s $\color{#35bf28}+1.81\%$
test_reinforce_speed[True-backward] 3.1762ms 2.9483ms 339.1746 Ops/s 321.2282 Ops/s $\textbf{\color{#35bf28}+5.59\%}$
test_reinforce_speed[reduce-overhead-None] 18.9140ms 10.1352ms 98.6661 Ops/s 100.4040 Ops/s $\color{#d91a1a}-1.73\%$
test_reinforce_speed[reduce-overhead-backward] 1.6297ms 1.5082ms 663.0322 Ops/s 592.8198 Ops/s $\textbf{\color{#35bf28}+11.84\%}$
test_iql_speed[False-None] 9.8587ms 9.1898ms 108.8161 Ops/s 106.8221 Ops/s $\color{#35bf28}+1.87\%$
test_iql_speed[False-backward] 13.4199ms 12.7733ms 78.2883 Ops/s 75.6195 Ops/s $\color{#35bf28}+3.53\%$
test_iql_speed[True-None] 2.5908ms 2.2471ms 445.0103 Ops/s 436.8958 Ops/s $\color{#35bf28}+1.86\%$
test_iql_speed[True-backward] 5.5189ms 4.9189ms 203.2966 Ops/s 198.3352 Ops/s $\color{#35bf28}+2.50\%$
test_iql_speed[reduce-overhead-None] 0.4977s 12.9273ms 77.3556 Ops/s 89.6873 Ops/s $\textbf{\color{#d91a1a}-13.75\%}$
test_iql_speed[reduce-overhead-backward] 2.0441ms 1.8933ms 528.1733 Ops/s 477.3577 Ops/s $\textbf{\color{#35bf28}+10.65\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.7855ms 6.2311ms 160.4856 Ops/s 157.6445 Ops/s $\color{#35bf28}+1.80\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6562ms 0.3368ms 2.9690 KOps/s 3.2771 KOps/s $\textbf{\color{#d91a1a}-9.40\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6568ms 0.2921ms 3.4240 KOps/s 3.8717 KOps/s $\textbf{\color{#d91a1a}-11.56\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.3073ms 5.9703ms 167.4967 Ops/s 165.2586 Ops/s $\color{#35bf28}+1.35\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.1463ms 0.3042ms 3.2870 KOps/s 3.1522 KOps/s $\color{#35bf28}+4.27\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6584ms 0.3002ms 3.3309 KOps/s 3.1858 KOps/s $\color{#35bf28}+4.56\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.7353ms 1.3634ms 733.4354 Ops/s 658.5154 Ops/s $\textbf{\color{#35bf28}+11.38\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.5045ms 1.2948ms 772.3070 Ops/s 719.0983 Ops/s $\textbf{\color{#35bf28}+7.40\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.3282ms 6.1417ms 162.8209 Ops/s 159.8137 Ops/s $\color{#35bf28}+1.88\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.1922ms 0.5013ms 1.9946 KOps/s 2.0956 KOps/s $\color{#d91a1a}-4.82\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8192ms 0.4482ms 2.2313 KOps/s 2.3173 KOps/s $\color{#d91a1a}-3.71\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 9.9100ms 6.1139ms 163.5629 Ops/s 162.6071 Ops/s $\color{#35bf28}+0.59\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9168ms 0.3541ms 2.8241 KOps/s 2.9609 KOps/s $\color{#d91a1a}-4.62\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6770ms 0.3298ms 3.0320 KOps/s 3.5397 KOps/s $\textbf{\color{#d91a1a}-14.35\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.4391ms 5.9501ms 168.0645 Ops/s 164.9914 Ops/s $\color{#35bf28}+1.86\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.2614ms 0.2663ms 3.7558 KOps/s 3.1983 KOps/s $\textbf{\color{#35bf28}+17.43\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.4682ms 0.2423ms 4.1274 KOps/s 3.5031 KOps/s $\textbf{\color{#35bf28}+17.82\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.4618ms 6.1761ms 161.9136 Ops/s 159.0079 Ops/s $\color{#35bf28}+1.83\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.0761ms 0.4169ms 2.3985 KOps/s 2.3519 KOps/s $\color{#35bf28}+1.98\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.6770ms 0.4052ms 2.4681 KOps/s 2.4244 KOps/s $\color{#35bf28}+1.80\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 6.9258ms 5.4664ms 182.9347 Ops/s 176.7615 Ops/s $\color{#35bf28}+3.49\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 9.7008ms 2.1249ms 470.6067 Ops/s 435.7155 Ops/s $\textbf{\color{#35bf28}+8.01\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 7.1754ms 1.2829ms 779.4855 Ops/s 792.6734 Ops/s $\color{#d91a1a}-1.66\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.4661s 14.8100ms 67.5218 Ops/s 176.4622 Ops/s $\textbf{\color{#d91a1a}-61.74\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 10.3755ms 2.1548ms 464.0910 Ops/s 444.4521 Ops/s $\color{#35bf28}+4.42\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 3.6155ms 1.1797ms 847.6757 Ops/s 856.7391 Ops/s $\color{#d91a1a}-1.06\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 10.5754ms 5.7894ms 172.7297 Ops/s 30.3552 Ops/s $\textbf{\color{#35bf28}+469.03\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 6.7754ms 2.1696ms 460.9212 Ops/s 511.0953 Ops/s $\textbf{\color{#d91a1a}-9.82\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 9.3112ms 1.4356ms 696.5556 Ops/s 710.8788 Ops/s $\color{#d91a1a}-2.01\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 14.0176ms 13.3205ms 75.0722 Ops/s 71.7626 Ops/s $\color{#35bf28}+4.61\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 18.3866ms 16.7924ms 59.5507 Ops/s 58.1815 Ops/s $\color{#35bf28}+2.35\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 18.2900ms 17.9755ms 55.6314 Ops/s 54.1044 Ops/s $\color{#35bf28}+2.82\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 18.7489ms 17.0014ms 58.8186 Ops/s 58.1419 Ops/s $\color{#35bf28}+1.16\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 18.4516ms 18.0406ms 55.4306 Ops/s 53.4732 Ops/s $\color{#35bf28}+3.66\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 19.6555ms 18.2985ms 54.6493 Ops/s 54.0289 Ops/s $\color{#35bf28}+1.15\%$

@vmoens
Update
b1a9c44 
[ghstack-poisoned]
@vmoens vmoens mentioned this pull request Mar 3, 2025
Merged
@vmoens
Update
688d12b 
[ghstack-poisoned]
This was referenced Mar 3, 2025
Merged
Merged
@vmoens vmoens merged commit 688d12b into gh/vmoens/97/base Mar 3, 2025
66 of 72 checks passed
vmoens added a commit that referenced this pull request Mar 3, 2025
@vmoens
[Lint] pyupgrade
40b147e 
ghstack-source-id: dcdf51db31b8f6bcfad7fd4dc53f5b5ad8098c5d
Pull Request resolved: #2819
@vmoens vmoens deleted the gh/vmoens/97/head branch March 3, 2025 15:50
vmoens added a commit that referenced this pull request Mar 8, 2025
@vmoens
[Lint] pyupgrade
55bd53a 
ghstack-source-id: dcdf51db31b8f6bcfad7fd4dc53f5b5ad8098c5d
Pull Request resolved: #2819

(cherry picked from commit 40b147e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoinebrl antoinebrl antoinebrl left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Data Data-related PR, will launch data-related jobs Environments Adds or modifies an environment wrapper formatting Code formatting changes major major refactoring in the code base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmoens @antoinebrl @facebook-github-bot