Fix audio seeks bugs #599
Merged
Fix audio seeks bugs #599
+17
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@NicolasHug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NicolasHug
changed the title
|
@NicolasHug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
scotts
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 audio-related bugs:
setCursorPtsInSecondsInternal: it accepted a double and we were passing it INT64_MIN. This led to over/underflowstop_secondsparameter can be None, in which case we were setting it tostd::numeric_limits<double>::max(), which was causing an overflow when that value was converted back to a int64 pts.