Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor C++ ops implementations #603

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

scotts
Copy link
Contributor

@scotts scotts commented Mar 28, 2025

This PR refactors two things:

  1. Removes VideoDecoderOps.h, the header file that declared all of the C++ custom ops. We actually don't need this anymore, as the purpose it served was to enable other C++ code to call the C++ custom ops. But we deleted the C++ test that did that, and now these functions are only ever called through their Python bindings. Removing this file simplifies our code and simplifies the process of adding a new custom op, which already has a bunch of steps. The comments in the header were valuable, so I moved them over.
  2. Renames the .cpp files that are the main logic for libtorchdoec_custom_ops.so and libtorchcodec_pybind_ops.so to match: custom_ops.cpp and pybind_ops.cpp.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 28, 2025
@scotts scotts marked this pull request as ready for review March 28, 2025 01:09
@scotts scotts requested a review from NicolasHug March 28, 2025 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants