Refactor C++ ops implementations #603
Open
+117
−218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors two things:
VideoDecoderOps.h
, the header file that declared all of the C++ custom ops. We actually don't need this anymore, as the purpose it served was to enable other C++ code to call the C++ custom ops. But we deleted the C++ test that did that, and now these functions are only ever called through their Python bindings. Removing this file simplifies our code and simplifies the process of adding a new custom op, which already has a bunch of steps. The comments in the header were valuable, so I moved them over.libtorchdoec_custom_ops.so
andlibtorchcodec_pybind_ops.so
to match:custom_ops.cpp
andpybind_ops.cpp
.