Add fused_params to mch sharders #1649
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52921362 |
henrylhtsang
added a commit
to henrylhtsang/torchrec
that referenced
this pull request
Jan 22, 2024
Summary: This diff is not really ideal. Ideally we can deprecate the sharder fused params path. The question is which one would happen first: 1. zch + uvm caching 2. the use of per table CLF. Differential Revision: D52921362
henrylhtsang
force-pushed
the
export-D52921362
branch
from
5e4c685 to
a0bffa4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52921362 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D52921362 |
Summary: Adding fused_params to zch. The main reason is so cache load factor passed through zch sharder.fused_params can be represented in planner stats. Reviewed By: dstaay-fb Differential Revision: D52921362
henrylhtsang
force-pushed
the
export-D52921362
branch
from
a0bffa4 to
e57f1f0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52921362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff is not really ideal. Ideally we can deprecate the sharder fused params path.
The question is which one would happen first:
Differential Revision: D52921362