Report the batch size used for the qps/throughput calculation #2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
ilyas409
force-pushed
the
export-D70892994
branch
from
9004e7a to
1c1e256
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70892994 |
|
This pull request was exported from Phabricator. Differential Revision: D70892994 |
ilyas409
force-pushed
the
export-D70892994
branch
from
1c1e256 to
e108b64
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70892994 |
ilyas409
pushed a commit
to ilyas409/torchrec
that referenced
this pull request
Mar 10, 2025
…h#2788) Summary: Pull Request resolved: pytorch#2788 If using batch size stages, also report the current batch size that was used for the throughput calculation Differential Revision: D70892994
ilyas409
force-pushed
the
export-D70892994
branch
from
e108b64 to
23b9ccb
Compare
ilyas409
pushed a commit
to ilyas409/torchrec
that referenced
this pull request
Mar 11, 2025
…h#2788) Summary: If using batch size stages, also report the current batch size that was used for the throughput calculation Differential Revision: D70892994
ilyas409
force-pushed
the
export-D70892994
branch
from
23b9ccb to
2aa61c4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70892994 |
ilyas409
force-pushed
the
export-D70892994
branch
from
2aa61c4 to
46bf15d
Compare
ilyas409
pushed a commit
to ilyas409/torchrec
that referenced
this pull request
Mar 11, 2025
…h#2788) Summary: Pull Request resolved: pytorch#2788 If using batch size stages, also report the current batch size that was used for the throughput calculation Differential Revision: D70892994
ilyas409
pushed a commit
to ilyas409/torchrec
that referenced
this pull request
Mar 11, 2025
…h#2788) Summary: If using batch size stages, also report the current batch size that was used for the throughput calculation Reviewed By: kausv Differential Revision: D70892994
ilyas409
force-pushed
the
export-D70892994
branch
from
46bf15d to
5deab66
Compare
…h#2788) Summary: Pull Request resolved: pytorch#2788 If using batch size stages, also report the current batch size that was used for the throughput calculation Reviewed By: kausv Differential Revision: D70892994
|
This pull request was exported from Phabricator. Differential Revision: D70892994 |
ilyas409
force-pushed
the
export-D70892994
branch
from
5deab66 to
9dd39b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: If using batch size stages, also report the current batch size that was used for the throughput calculation
Differential Revision: D70892994