Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust aws_c5.18xlarge memory size #991

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: adjust aws_c5.18xlarge memory size #991

wants to merge 1 commit into from

Conversation

clumsy
Copy link
Contributor

@clumsy clumsy commented Dec 13, 2024

MEM_TAX is not enough to adjust memory size for the actual memory we get:

              total        used        free      shared  buff/cache   available
Mem:      144113336     1443996   140375536         812     2293804   141697752
Swap:             0           0           0

Test plan:

  • Submitted a training job using 142 * GiB

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 13, 2024
@clumsy
Copy link
Contributor Author

clumsy commented Dec 13, 2024

Please let me know if this needs to be updated, @kiukchung. Thanks!

@clumsy
Copy link
Contributor Author

clumsy commented Dec 20, 2024

Could you please check this small PR, @kiukchung @d4l3k?

@kiukchung
Copy link
Collaborator

I seem to have lost approve/merge/run-workflow access to this repo... cc) @d4l3k @yikaiMeta

@clumsy
Copy link
Contributor Author

clumsy commented Feb 17, 2025

Could you please have a look, @tonykao8080?

tonykao8080
tonykao8080 approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@tonykao8080 tonykao8080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@clumsy
Copy link
Contributor Author

clumsy commented Feb 18, 2025

Thanks @tonykao8080 let me amend+force-push to kick-start that linter check

@clumsy
Copy link
Contributor Author

clumsy commented Feb 18, 2025

My bad, @tonykao8080 used main for my other PR also (last time not using feature branches 😁).

This time the change is right and hopefully the linter will start too.

@clumsy clumsy force-pushed the main branch 2 times, most recently from de37faf to 0fe4c85 Compare February 19, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonykao8080 tonykao8080 tonykao8080 approved these changes

@kiukchung kiukchung kiukchung approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clumsy @kiukchung @tonykao8080 @facebook-github-bot @azzhipa