[Draft] Add Experimental limited sparse embedding bag #8905
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users of
torch_xla
encounter an issue when using thesparse=True
option with theEmbedding
orEmbeddingBag
modules.The gradient for weight is created as a sparse tensor and there is no dispatch registered for the combination of sparse creation APIs w/ the
XLA
key, or theSparse
functionality key and theXLA
backed key used in conjunction.This is a workaround that can be removed, ported to C++, or extended later:
F.embedding
F.embedding_bag
,nn.Embedding
, andnn.EmbeddingBag
which forward to a custom implementation of the backward and produce the above tensor subclass rather than a native torch sparse tensor.The tensor subclass may have component tensors
indices
andvalues
which have xla device without issue.fixes #8719