Add extend option to add_text
#36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhoese
reviewed
Mar 28, 2023
Comment on lines
+281
to
+289
| if self.style["extend"]: | ||
| if self.style["propagation"][0] == 1: | ||
| x1 = x + px * (x_size - x) | ||
| elif self.style["propagation"][0] == -1: | ||
| x1 = x + px * x | ||
| else: | ||
| x1 = x + px * (tw + 2 * mx) | ||
| else: | ||
| x1 = x + px * (tw + 2 * mx) |
There was a problem hiding this comment.
Could we put this in another helper function or method? And how similar is this code to the scale/colorbar code? Could it be reused?
What do you think about a test that just makes sure that the result is different based on extend False and extend True? It doesn't have to check actual pixel-by-pixel comparison.
Pull Request Test Coverage Report for Build 4547122869
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, adding a colorbar to an image has the
extendoption, which expands the colorbar to fill the entire width/height.This PR adds a similar
extendkwarg to_add_text, enabling a textbox to take up the width of the image.