Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in using TLES env variable #143

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Jan 31, 2024

The behaviour of using TLES environment variable was changed in #129. This PR reverts the usage so that TLES='/path/to/tle_files/tle*txt" works again.

The question is, should the TLES=/path/to/tle_files" introduced in #129 work?

  • Tests adjusted
  • Tests passed
  • Fully documented
  • Passes flake8 pyorbital

@pnuu pnuu added the bug label Jan 31, 2024
@pnuu pnuu requested review from mraspaud and adybbroe January 31, 2024 08:15
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c06303) 87.51% compared to head (97df4c1) 87.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage   87.51%   87.51%           
=======================================
  Files          14       14           
  Lines        2210     2210           
=======================================
  Hits         1934     1934           
  Misses        276      276           
Flag Coverage Δ
unittests 87.51% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Jan 31, 2024

Coverage Status

coverage: 87.562%. remained the same
when pulling 97df4c1 on pnuu:bugfix-local-tles
into 2c06303 on pytroll:main.

@pnuu pnuu self-assigned this Jan 31, 2024
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But I'd like this do be double-checked by @adybbroe

@mraspaud
Copy link
Member

mraspaud commented Feb 5, 2024

It's actually a feature, not a bug... but the new behaviour in 1.8 is actually problematic, so we are reverting this here.

@mraspaud mraspaud merged commit 453218b into pytroll:main Feb 5, 2024
17 checks passed
@pnuu pnuu deleted the bugfix-local-tles branch February 5, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants