-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI to use Python 3.10 - 3.12 and plain Miniforge #146
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
=======================================
Coverage 88.12% 88.12%
=======================================
Files 14 14
Lines 2265 2265
=======================================
Hits 1996 1996
Misses 269 269
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But why are the CI tests failing? Any idea?
Lets see if switching from Mambaforge to plain |
This will use miniforge, not miniconda, right? |
python-version: ${{ matrix.python-version }} | ||
activate-environment: test-environment | ||
channels: conda-forge | ||
conda-remove-defaults: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's neat!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Borrowed from Satpy (which I apparently also did 🙈 😂).
Oh right, Miniforge, not Miniconda. I just thought from the action |
Update CI to use Python versions 3.10, 3.11 and 3.12.
In addition switch from Mambaforge (which is deprecated) to plain Miniforge.