Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to use Python 3.10 - 3.12 and plain Miniforge #146

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Feb 16, 2024

Update CI to use Python versions 3.10, 3.11 and 3.12.

In addition switch from Mambaforge (which is deprecated) to plain Miniforge.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.12%. Comparing base (04e53e9) to head (eb37c5a).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files          14       14           
  Lines        2265     2265           
=======================================
  Hits         1996     1996           
  Misses        269      269           
Flag Coverage Δ
unittests 88.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@coveralls
Copy link

Coverage Status

coverage: 87.562%. remained the same
when pulling c9a139e on pnuu:update-ci-python
into e8e55cb on pytroll:main.

@adybbroe adybbroe self-assigned this Nov 20, 2024
@adybbroe adybbroe requested review from mraspaud, djhoese, a team and sfinkens and removed request for djhoese and mraspaud November 20, 2024 15:31
Copy link
Contributor

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But why are the CI tests failing? Any idea?

@pnuu
Copy link
Member Author

pnuu commented Nov 20, 2024

Lets see if switching from Mambaforge to plain Miniconda Miniforge helps.

@pnuu pnuu changed the title Update CI to use Python 3.10 - 3.12 Update CI to use Python 3.10 - 3.12 and plain Miniconda Nov 20, 2024
@coveralls
Copy link

Coverage Status

coverage: 88.06%. remained the same
when pulling eb37c5a on pnuu:update-ci-python
into 8e7de83 on pytroll:main.

@mraspaud
Copy link
Member

This will use miniforge, not miniconda, right?

python-version: ${{ matrix.python-version }}
activate-environment: test-environment
channels: conda-forge
conda-remove-defaults: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's neat!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Borrowed from Satpy (which I apparently also did 🙈 😂).

@pnuu
Copy link
Member Author

pnuu commented Nov 20, 2024

Oh right, Miniforge, not Miniconda. I just thought from the action conda-incubator/setup-miniconda@v3 name that it'd be Miniconda. From the logs it's evident it is Miniforge, which is even better. I'll update the topic and description.

@pnuu pnuu changed the title Update CI to use Python 3.10 - 3.12 and plain Miniconda Update CI to use Python 3.10 - 3.12 and plain Miniforge Nov 20, 2024
@adybbroe adybbroe merged commit 19f444b into pytroll:main Nov 20, 2024
17 checks passed
@pnuu pnuu deleted the update-ci-python branch November 20, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants