Add better dtype preservation in astronomy functions with numpy 2 #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using numpy 2 is revealing a lot of spots in the astronomy functions where 32-bit floats/datetimes are being promoted/upcasted to 64-bit floats. This PR is an overhaul of type annotations and tests and dtype checks in order to try to clean this up a bit. But with all the type annotations it has started to get less clean. I've always had trouble though with understanding what arguments were what type so hopefully this is a start toward better descriptions of those.
flake8 pyorbital