Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datetime imports #177

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Fix datetime imports #177

merged 1 commit into from
Dec 13, 2024

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Dec 13, 2024

As discussed in #175 , it is better to use import datetime as dt instead of from datetime import datetime so that the module name does not replace the package preventing usage of previously unimported modules. This PR fixes the imports.

@pnuu pnuu self-assigned this Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 12 lines in your changes missing coverage. Please review.

Project coverage is 87.83%. Comparing base (16f71f7) to head (3384cf8).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pyorbital/orbital.py 46.66% 8 Missing ⚠️
pyorbital/geoloc.py 0.00% 2 Missing ⚠️
pyorbital/geoloc_example.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files          16       16           
  Lines        2630     2630           
=======================================
  Hits         2310     2310           
  Misses        320      320           
Flag Coverage Δ
unittests 87.83% <78.94%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 87.798%. remained the same
when pulling 3384cf8 on pnuu:fix-datetime-imports
into 932c493 on pytroll:main.

@djhoese djhoese merged commit d843af4 into pytroll:main Dec 13, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants