Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get_observer_look work on oblate earth #87

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mraspaud
Copy link
Member

The pyorbital code to compute the observer look was making the assumption that the earth was spherical. While the differences are quite small, we implement here the oblateness of the earth into the function.

@mraspaud mraspaud self-assigned this Nov 12, 2021
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #87 (6785eed) into main (e215868) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   85.67%   85.55%   -0.12%     
==========================================
  Files          13       13              
  Lines        1947     1932      -15     
==========================================
- Hits         1668     1653      -15     
  Misses        279      279              
Flag Coverage Δ
unittests 85.55% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyorbital/orbital.py 86.60% <100.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e215868...6785eed. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants