Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slstr #98

Merged
merged 13 commits into from
Nov 27, 2024
Merged

Add slstr #98

merged 13 commits into from
Nov 27, 2024

Conversation

TAlonglong
Copy link

inst = np.tile(inst[:, np.newaxis, :], [1, np.int32(scans_nb), 1])

times = np.tile(np.zeros_like(scanline_angles), [np.int32(scans_nb), 1])

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W293 blank line contains whitespace

"""Test the definition of the slstr instrument flying on Sentinel-3
"""
geom = slstr(1, [0, 1])

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W293 blank line contains whitespace

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.45%. Comparing base (e27a1d4) to head (7eb57a5).
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   87.94%   88.45%   +0.51%     
==========================================
  Files          16       16              
  Lines        2306     2391      +85     
==========================================
+ Hits         2028     2115      +87     
+ Misses        278      276       -2     
Flag Coverage Δ
unittests 88.45% <100.00%> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TAlonglong
Copy link
Author

Could someone add appropriate tags to this issue? And who can review this?

@TAlonglong
Copy link
Author

This PR is needed before issue 69 in pytroll-schedule can reviewed.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, just a couple of comments

@@ -553,3 +553,33 @@ def ascat(scan_nb, scan_points=None):
[np.int32(scan_nb), 1]) + np.expand_dims(offset, 1))

return ScanGeometry(inst, times)


def slstr(scans_nb, scan_points=None, is_nadir=True):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be called eg slstr_nadir?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

pyorbital/geoloc_instrument_definitions.py Outdated Show resolved Hide resolved
@adybbroe
Copy link
Contributor

@TAlonglong
Do you have time looking at this again, see comments above?

@adybbroe
Copy link
Contributor

@TAlonglong Should we finish up this one?

@coveralls
Copy link

coveralls commented Nov 23, 2024

Coverage Status

coverage: 88.414% (+0.5%) from 87.904%
when pulling 7eb57a5 on TAlonglong:add-slstr-instument-definition
into 9700076 on pytroll:main.

@TAlonglong
Copy link
Author

Oh man, this is old. I will try to have a look.

@adybbroe adybbroe requested review from pnuu and mraspaud November 26, 2024 16:10
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my comment from earlier still stands, but otherwise I’m good with this.

@TAlonglong
Copy link
Author

Please have a look again.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnuu pnuu merged commit 1e651fb into pytroll:main Nov 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants