Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NetCDF file cache handling compatible with dask distributed #2822

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Broaden test match string for test_filenotfound

ec76fa6
Select commit
Loading
Failed to load commit list.
Open

Make NetCDF file cache handling compatible with dask distributed #2822

Broaden test match string for test_filenotfound
ec76fa6
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jun 20, 2024 in 50s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Excess Number of Function Arguments utils.py: get_distributed_friendly_dask_array
  • Excess Number of Function Arguments test_utils.py: TestDistributed.test_get_distributed_friendly_dask_array

Annotations

Check warning on line 527 in satpy/readers/utils.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments 

get_distributed_friendly_dask_array has 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 572 in satpy/tests/reader_tests/test_utils.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments 

TestDistributed.test_get_distributed_friendly_dask_array has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
View more details on CodeScene Delta Analysis