-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce test warnings #202
Reduce test warnings #202
Conversation
I'm not actually sure we can start using timezone-aware datetimes before Satpy and everything else is doing that. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
+ Coverage 95.87% 95.93% +0.06%
==========================================
Files 12 12
Lines 3052 3052
==========================================
+ Hits 2926 2928 +2
+ Misses 126 124 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
See also pytroll/satpy#2752 |
For Python 3.12 the number of warnings dropped from 897 to 17 (locally, 16 on CI where there's a newer The |
The leftover warnings:
Easy to get rid off by adding |
The warning about losing projection information was actually coming from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing these, lgtm.
This PR aims at reducing warnings emitted when running the tests.
✔️ Needs rebasing after #201 has been merged.
flake8 trollflow2
AUTHORS.md
if not there already