Fix log message printing the number of loaded composites #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
==========================================
+ Coverage 95.99% 96.00% +0.01%
==========================================
Files 14 14
Lines 3293 3305 +12
==========================================
+ Hits 3161 3173 +12
Misses 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gerritholl
approved these changes
Nov 15, 2024
Comment on lines
+847
to
+850
| @pytest.fixture(autouse=True) | ||
| def inject_fixtures(self, caplog): | ||
| """Inject fixtures.""" | ||
| self._caplog = caplog |
There was a problem hiding this comment.
What is the benefit of storing a _caplog attribute and using that, rather than using the caplog attribute in the tests directly?
There was a problem hiding this comment.
This is the only way to use fixtures in unittest.TestCase classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trollflow2 is printing a log message saying
Loading 1 compositeseven when there are more. This PR fixes the log message.flake8 trollflow2