Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put output dir to tmp_path #224

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Nov 15, 2024

The TestSaveDatasets.test_pop_unknown_args is creating a Hungarian directory and not removing it. This PR fixes it by using tmp_path fixture.

@pnuu pnuu added the bug Something isn't working label Nov 15, 2024
@pnuu pnuu requested a review from gerritholl November 15, 2024 08:46
@pnuu pnuu self-assigned this Nov 15, 2024
@pnuu pnuu requested a review from mraspaud as a code owner November 15, 2024 08:46
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.96%. Comparing base (98355d9) to head (f834043).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files          14       14           
  Lines        3268     3272    +4     
=======================================
+ Hits         3136     3140    +4     
  Misses        132      132           
Flag Coverage Δ
unittests 95.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gerritholl gerritholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think with all the mocking anything would be created at all, but looks good to me.

@pnuu pnuu merged commit 88df3d4 into pytroll:main Nov 18, 2024
9 checks passed
@pnuu pnuu deleted the fix-hungarian-output-dir branch November 18, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test directory not removed after tests
3 participants