Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update versioneer #183

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Update versioneer #183

merged 3 commits into from
Oct 10, 2023

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Oct 9, 2023

The old versioneer is not compatible with python 3.12, this PR updates versioneer

@mraspaud mraspaud added the bug label Oct 9, 2023
@mraspaud mraspaud self-assigned this Oct 9, 2023
@mraspaud mraspaud requested a review from pnuu as a code owner October 9, 2023 09:15
@TAlonglong TAlonglong self-requested a review October 9, 2023 15:17
TAlonglong
TAlonglong reviewed Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@TAlonglong TAlonglong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is big. Is some of this updated automatically?

@djhoese
Copy link
Member

djhoese commented Oct 9, 2023

@TAlonglong Yes, this is all automatic when you update versioneer. I think you do pip install -U versioneer then versioneer install and versioneer just updates all the files.

pnuu
pnuu approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnuu pnuu merged commit 53cb2dc into pytroll:main Oct 10, 2023
4 checks passed
@mraspaud mraspaud deleted the update-versioneer branch October 10, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TAlonglong TAlonglong TAlonglong left review comments

@pnuu pnuu pnuu approved these changes

Assignees

@mraspaud mraspaud

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mraspaud @djhoese @pnuu @TAlonglong