Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for newer fsspec #204

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

mraspaud
Copy link
Member

This PR fixes the tests broken by the new json serialisation format in newer ffspec versions.

@mraspaud mraspaud added the bug label Jun 17, 2024
@mraspaud mraspaud self-assigned this Jun 17, 2024
@mraspaud mraspaud requested a review from pnuu as a code owner June 17, 2024 11:40
Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnuu pnuu merged commit 91cf8e0 into pytroll:main Jun 17, 2024
7 checks passed
@mraspaud mraspaud deleted the fix-test-for-new-fsspec branch June 17, 2024 12:24
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.72%. Comparing base (dcb9427) to head (492cd85).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   91.66%   91.72%   +0.05%     
==========================================
  Files          28       28              
  Lines        5666     5666              
==========================================
+ Hits         5194     5197       +3     
+ Misses        472      469       -3     
Flag Coverage Δ
unittests 91.72% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants