Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pyproject.toml #75

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Switch to pyproject.toml #75

merged 4 commits into from
Nov 22, 2024

Conversation

sfinkens
Copy link
Member

@sfinkens sfinkens commented Nov 22, 2024

Replace setup.py/cfg and versioneer.py with pyproject.toml. I copied the hatchling config from Satpy.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.01%. Comparing base (c9163e3) to head (8f96a05).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   96.05%   96.01%   -0.05%     
==========================================
  Files           8        5       -3     
  Lines         609      602       -7     
==========================================
- Hits          585      578       -7     
  Misses         24       24              
Flag Coverage Δ
unittests 96.01% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfinkens sfinkens requested review from djhoese and pnuu November 22, 2024 11:55
Copy link
Contributor

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM.
Should improved code style checking with ruff for instance be added in a different PR?

@adybbroe adybbroe added the packaging Dealing with setup.py or other package building label Nov 22, 2024
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mraspaud mraspaud merged commit f427e3f into pytroll:main Nov 22, 2024
12 of 13 checks passed
@sfinkens
Copy link
Member Author

Should improved code style checking with ruff for instance be added in a different PR?

I'll give it a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement packaging Dealing with setup.py or other package building
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants