Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3 Add release workflow #7

Merged
merged 3 commits into from
Oct 21, 2024
Merged

#3 Add release workflow #7

merged 3 commits into from
Oct 21, 2024

Conversation

leewesleyv
Copy link
Collaborator

Resolves #3

Adds a workflow that triggers a GitHub action on creating a new release. This workflow build the package and publishes it to PyPI.

wvengen
wvengen reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@wvengen wvengen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :) One question, otherwise eager to get this merged!

Please provide an empty line between each step (as we do in other projects).

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@wvengen
Copy link
Member

wvengen commented Oct 21, 2024

Let's first publish on test.pypi now (as per your request).

@leewesleyv leewesleyv merged commit 93ef8c9 into main Oct 21, 2024
6 checks passed
@leewesleyv leewesleyv deleted the feature/3-release-workflow branch October 21, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvengen wvengen wvengen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workflow for releasing to PyPI
2 participants
@leewesleyv @wvengen