Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up #33

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Tidy up #33

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed5e2e1
Fix SetPayload log message
russcam Nov 27, 2023
1766db7
don't set filter twice
russcam Nov 27, 2023
066cc98
refine xml docs
russcam Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 15 additions & 18 deletions src/Qdrant.Client/QdrantClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1516,7 +1516,7 @@ private async Task<UpdateResult> SetPayloadAsync(
if (ordering is not null)
request.Ordering = new() { Type = ordering.Value };

_logger.Count(collectionName);
_logger.SetPayload(collectionName);

try
{
Expand Down Expand Up @@ -1563,7 +1563,7 @@ public Task<UpdateResult> OverwritePayloadAsync(
/// </summary>
/// <param name="collectionName">The name of the collection.</param>
/// <param name="payload">New payload values.</param>
/// <param name="id">The ID for which to set the payload.</param>
/// <param name="id">The ID for which to overwrite the payload.</param>
/// <param name="wait">Whether to wait until the changes have been applied. Defaults to <c>true</c>.</param>
/// <param name="ordering">Write ordering guarantees.</param>
/// <param name="cancellationToken">
Expand All @@ -1588,7 +1588,7 @@ public Task<UpdateResult> OverwritePayloadAsync(
/// </summary>
/// <param name="collectionName">The name of the collection.</param>
/// <param name="payload">New payload values.</param>
/// <param name="ids">The IDs for which to set the payload.</param>
/// <param name="ids">The IDs for which to overwrite the payload.</param>
/// <param name="wait">Whether to wait until the changes have been applied. Defaults to <c>true</c>.</param>
/// <param name="ordering">Write ordering guarantees.</param>
/// <param name="cancellationToken">
Expand All @@ -1614,7 +1614,7 @@ public Task<UpdateResult> OverwritePayloadAsync(
/// </summary>
/// <param name="collectionName">The name of the collection.</param>
/// <param name="payload">New payload values.</param>
/// <param name="id">The ID for which to set the payload.</param>
/// <param name="id">The ID for which to overwrite the payload.</param>
/// <param name="wait">Whether to wait until the changes have been applied. Defaults to <c>true</c>.</param>
/// <param name="ordering">Write ordering guarantees.</param>
/// <param name="cancellationToken">
Expand All @@ -1639,7 +1639,7 @@ public Task<UpdateResult> OverwritePayloadAsync(
/// </summary>
/// <param name="collectionName">The name of the collection.</param>
/// <param name="payload">New payload values.</param>
/// <param name="ids">The IDs for which to set the payload.</param>
/// <param name="ids">The IDs for which to overwrite the payload.</param>
/// <param name="wait">Whether to wait until the changes have been applied. Defaults to <c>true</c>.</param>
/// <param name="ordering">Write ordering guarantees.</param>
/// <param name="cancellationToken">
Expand Down Expand Up @@ -1751,7 +1751,7 @@ public Task<UpdateResult> DeletePayloadAsync(
/// </summary>
/// <param name="collectionName">The name of the collection.</param>
/// <param name="keys">List of keys to delete.</param>
/// <param name="id">The ID for which to set the payload.</param>
/// <param name="id">The ID for which to delete the payload.</param>
/// <param name="wait">Whether to wait until the changes have been applied. Defaults to <c>true</c>.</param>
/// <param name="ordering">Write ordering guarantees.</param>
/// <param name="cancellationToken">
Expand All @@ -1776,7 +1776,7 @@ public Task<UpdateResult> DeletePayloadAsync(
/// </summary>
/// <param name="collectionName">The name of the collection.</param>
/// <param name="keys">List of keys to delete.</param>
/// <param name="ids">The IDs for which to set the payload.</param>
/// <param name="ids">The IDs for which to delete the payload.</param>
/// <param name="wait">Whether to wait until the changes have been applied. Defaults to <c>true</c>.</param>
/// <param name="ordering">Write ordering guarantees.</param>
/// <param name="cancellationToken">
Expand All @@ -1802,7 +1802,7 @@ public Task<UpdateResult> DeletePayloadAsync(
/// </summary>
/// <param name="collectionName">The name of the collection.</param>
/// <param name="keys">List of keys to delete.</param>
/// <param name="id">The ID for which to set the payload.</param>
/// <param name="id">The ID for which to delete the payload.</param>
/// <param name="wait">Whether to wait until the changes have been applied. Defaults to <c>true</c>.</param>
/// <param name="ordering">Write ordering guarantees.</param>
/// <param name="cancellationToken">
Expand All @@ -1827,7 +1827,7 @@ public Task<UpdateResult> DeletePayloadAsync(
/// </summary>
/// <param name="collectionName">The name of the collection.</param>
/// <param name="keys">List of keys to delete.</param>
/// <param name="ids">The IDs for which to set the payload.</param>
/// <param name="ids">The IDs for which to delete the payload.</param>
/// <param name="wait">Whether to wait until the changes have been applied. Defaults to <c>true</c>.</param>
/// <param name="ordering">Write ordering guarantees.</param>
/// <param name="cancellationToken">
Expand Down Expand Up @@ -1934,7 +1934,7 @@ public Task<UpdateResult> ClearPayloadAsync(
/// Remove all payload for specified points.
/// </summary>
/// <param name="collectionName">The name of the collection.</param>
/// <param name="id">The ID for which to set the payload.</param>
/// <param name="id">The ID for which to remove the payload.</param>
/// <param name="wait">Whether to wait until the changes have been applied. Defaults to <c>true</c>.</param>
/// <param name="ordering">Write ordering guarantees.</param>
/// <param name="cancellationToken">
Expand All @@ -1956,7 +1956,7 @@ public Task<UpdateResult> ClearPayloadAsync(
/// Remove all payload for specified points.
/// </summary>
/// <param name="collectionName">The name of the collection.</param>
/// <param name="ids">The IDs for which to set the payload.</param>
/// <param name="ids">The IDs for which to remove the payload.</param>
/// <param name="wait">Whether to wait until the changes have been applied. Defaults to <c>true</c>.</param>
/// <param name="ordering">Write ordering guarantees.</param>
/// <param name="cancellationToken">
Expand All @@ -1980,7 +1980,7 @@ public Task<UpdateResult> ClearPayloadAsync(
/// Remove all payload for specified points.
/// </summary>
/// <param name="collectionName">The name of the collection.</param>
/// <param name="id">The ID for which to set the payload.</param>
/// <param name="id">The ID for which to remove the payload.</param>
/// <param name="wait">Whether to wait until the changes have been applied. Defaults to <c>true</c>.</param>
/// <param name="ordering">Write ordering guarantees.</param>
/// <param name="cancellationToken">
Expand All @@ -2003,7 +2003,7 @@ public Task<UpdateResult> ClearPayloadAsync(
/// Remove all payload for specified points.
/// </summary>
/// <param name="collectionName">The name of the collection.</param>
/// <param name="ids">The IDs for which to set the payload.</param>
/// <param name="ids">The IDs for which to remove the payload.</param>
/// <param name="wait">Whether to wait until the changes have been applied. Defaults to <c>true</c>.</param>
/// <param name="ordering">Write ordering guarantees.</param>
/// <param name="cancellationToken">
Expand All @@ -2027,7 +2027,7 @@ public Task<UpdateResult> ClearPayloadAsync(
/// Remove all payload for specified points.
/// </summary>
/// <param name="collectionName">The name of the collection.</param>
/// <param name="filter">A filter selecting the points to be overwritten.</param>
/// <param name="filter">A filter selecting the points for which to remove the payload.</param>
/// <param name="wait">Whether to wait until the changes have been applied. Defaults to <c>true</c>.</param>
/// <param name="ordering">Write ordering guarantees.</param>
/// <param name="cancellationToken">
Expand Down Expand Up @@ -2087,7 +2087,7 @@ private async Task<UpdateResult> ClearPayloadAsync(
/// </summary>
/// <param name="collectionName">The name of the collection.</param>
/// <param name="fieldName">Field name to index.</param>
/// <param name="schemaType">Field name to index.</param>
/// <param name="schemaType">The schema type of the field.</param>
/// <param name="indexParams">Payload index params.</param>
/// <param name="wait">Whether to wait until the changes have been applied. Defaults to <c>true</c>.</param>
/// <param name="ordering">Write ordering guarantees.</param>
Expand Down Expand Up @@ -2236,9 +2236,6 @@ public async Task<IReadOnlyList<ScoredPoint>> SearchAsync(

Populate(request.Vector, vector);

if (filter is not null)
request.Filter = filter;

if (filter is not null)
request.Filter = filter;

Expand Down