Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added new version update instructions #69

Merged
merged 3 commits into from
Oct 10, 2024
Merged

docs: Added new version update instructions #69

merged 3 commits into from
Oct 10, 2024

Conversation

Anush008
Copy link
Member

@Anush008 Anush008 commented Oct 1, 2024

As the title goes

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated

```bash
.\build.bat build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build exe that this invokes only downloads files from a given <QdrantVersion> once

if (Directory.Exists(protosTagDir) && Directory.EnumerateFileSystemEntries(protosTagDir).Any())
{
Console.WriteLine($"Already downloaded protos for {qdrantVersion}");
return;
}

For a constantly changing upstream branch like dev, may want to either

  • introduce a command line argument to delete the downloaded proto files

or

  • introduce a convention to delete downloaded proto files for given <QdrantVersion>s

Copy link
Member Author

@Anush008 Anush008 Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Added a new flag.
3c334be (#69)

@Anush008 Anush008 merged commit 0846503 into main Oct 10, 2024
2 checks passed
@Anush008 Anush008 deleted the contrib-guide branch October 10, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants