-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualize discovery scores #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the PR, there is some magic at the end I don't entirely understand due to the lack of types context, my comments are just symbolic as this is just a draft :)
} | ||
|
||
// Add tag to know which points were returned by the query | ||
queryResponse.data.result = queryResponse.data.result.map((point) => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better not to modify the original object and instead do:
const result = queryResponse.data.result.map(...)
const bodyFont = toFont(tooltipModel.options.bodyFont); | ||
|
||
// Display, position, and set styles for font | ||
tooltipEl.style.opacity = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move the creation and styling to a separate function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is trivial to separate these two things, since we are already styling within the jsx part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please check once that it works on Safari and Firefox before merging?
Good check, it works fine in Chrome, Firefox and Safari |
659238f
to
0192aef
Compare
Improves upon the existing visualizer to add the option of also seeing how discovery/context search looks when the score is colored
Internal hackathon submission
Play around with it, this demo is mostly useful for trying out context search (no target)
docker run -d -p 6333:6333 qdrant/qdrant && npm start
http://localhost:5173
food
Example
I'm someone who likes italian food. Let's think of a few examples:
For this context, check out how it looks:
Internals
Qdrant pain points
I encountered these issues that could improve in qdrant to make it a little nicer to work with
/scroll
endpoint returns its points in{ "points": ... }
while searches have{ "result": ...}
. This is not easy to fix since changes interface.