Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Commands" tooltip on hover to the list commands Button in Console View #139

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Add "Commands" tooltip on hover to the list commands Button in Console View #139

merged 3 commits into from
Jan 17, 2024

Conversation

Snehil-Shah
Copy link
Contributor

Fixes #138

image

trean
trean reviewed Jan 15, 2024
View reviewed changes
Copy link
Contributor

@trean trean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Could you please run npm run format and then commit changes so that we could merge this PR?

@Snehil-Shah
Format Code: npm run format
b791bd4 
Signed-off-by: Snehil Shah <[email protected]>
Snehil-Shah
Snehil-Shah commented Jan 15, 2024
View reviewed changes
Copy link
Contributor Author

@Snehil-Shah Snehil-Shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Could you please run npm run format and then commit changes so that we could merge this PR?

Done

trean
trean approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@trean trean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@Snehil-Shah
Fix Failing ESLint Checks
6881635 
Signed-off-by: Snehil Shah <[email protected]>
@Snehil-Shah
Copy link
Contributor Author

@kartik-gupta-ij Ran npm audit fix to fix the failing workflow, can you run it again?

@trean trean merged commit 5a6c4eb into qdrant:master Jan 17, 2024
1 check passed
@trean trean mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trean trean trean approved these changes

@kartik-gupta-ij kartik-gupta-ij kartik-gupta-ij approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Commands" tooltip to the list commands icon
3 participants
@Snehil-Shah @trean @kartik-gupta-ij