Merge pull request #1797 from qdraw/feature/202411_suggest_error_400

add test for suggest 400 && fix issue

starsky/starsky/Controllers/SearchSuggestController.cs

@@ -1,3 +1,4 @@
+using System.Collections.Generic;
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Mvc;
@@ -29,9 +30,10 @@ public SearchSuggestController(ISearchSuggest suggest)
 	// ^ ^ ^ ^ = = = = = = = = = = = = = = = = = =
 	public async Task<IActionResult> Suggest(string t)
 	{
-		if ( string.IsNullOrEmpty(t) )
+		if ( string.IsNullOrWhiteSpace(t) )
 		{
 			CacheControlOverwrite.SetExpiresResponseHeaders(Request); // 4 weeks
+			return Json(new List<string>());
 		}
 
 		if ( !ModelState.IsValid )

starsky/starskytest/Controllers/SearchSuggestControllerTest.cs

@@ -70,13 +70,20 @@ public async Task Suggestion_IsMoreThan10()
 	}
 
 	[TestMethod]
-	public async Task Suggestion_Nothing()
+	[DataRow(null)]
+	[DataRow("")]
+	[DataRow(" ")]
+	public async Task Suggestion_Nothing(string t)
 	{
 		var controller = new SearchSuggestController(_searchSuggest)
 		{
 			ControllerContext = { HttpContext = new DefaultHttpContext() }
 		};
-		var result = await controller.Suggest(string.Empty) as JsonResult;
+
+		// this will hit ModelState.IsValid
+		controller.ModelState.AddModelError("Key", "ErrorMessage");
+
+		var result = await controller.Suggest(t) as JsonResult;
 		var list = result!.Value as List<string>;
 
 		Assert.IsFalse(list!.Count != 0);

starsky/starskytest/starsky.foundation.native/OpenApplicationNative/Helpers/WindowsSetFileAssociationsTests.cs

@@ -6,6 +6,7 @@
 using starsky.foundation.platform.Models;
 using starskytest.FakeCreateAn.CreateFakeStarskyExe;
 using System.Text.RegularExpressions;
+using System.Threading.Tasks;
 
 namespace starskytest.starsky.foundation.native.OpenApplicationNative.Helpers;
 
@@ -53,7 +54,7 @@ private static void CleanSetup()
 	}
 
 	[TestMethod]
-	public void WindowsSetFileAssociations_EnsureAssociationsSet()
+	public async Task WindowsSetFileAssociations_EnsureAssociationsSet()
 	{
 		if ( !new AppSettings().IsWindows )
 		{
@@ -72,7 +73,13 @@ public void WindowsSetFileAssociations_EnsureAssociationsSet()
 			});
 
 		var valueKey = GetRegistryValue();
-		valueKey ??= GetRegistryValue();
+
+		if ( valueKey == null )
+		{
+			Console.WriteLine("Registry key not found, waiting for registry to update");
+			await Task.Delay(1000); // Wait for the registry to update
+			valueKey = GetRegistryValue();
+		}
 
 		Assert.IsNotNull(valueKey);
 		var match = GetFilePathFromRegistryRegex().Match(valueKey);