Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some code smells #1271

Merged
merged 31 commits into from
Nov 7, 2023

code smells

63163db
Select commit
Loading
Failed to load commit list.
Merged

fix some code smells #1271

code smells
63163db
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Nov 7, 2023 in 1s

91.86% of diff hit (target 75.00%)

View this Pull Request on Codecov

91.86% of diff hit (target 75.00%)

Annotations

Check warning on line 74 in starsky/starsky/clientapp/src/components/atoms/file-hash-image/pan-and-zoom-image.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

starsky/starsky/clientapp/src/components/atoms/file-hash-image/pan-and-zoom-image.tsx#L74 

Added line #L74 was not covered by tests

Check warning on line 145 in starsky/starsky/clientapp/src/components/organisms/menu-search/menu-search.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

starsky/starsky/clientapp/src/components/organisms/menu-search/menu-search.tsx#L145 

Added line #L145 was not covered by tests

Check warning on line 124 in starsky/starsky/clientapp/src/containers/detailview/detailview.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

starsky/starsky/clientapp/src/containers/detailview/detailview.tsx#L124 

Added line #L124 was not covered by tests

Check warning on line 274 in starsky/starsky/clientapp/src/containers/detailview/detailview.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

starsky/starsky/clientapp/src/containers/detailview/detailview.tsx#L274 

Added line #L274 was not covered by tests
View more details on Codecov